Review main Abandoned Breaking

90906[!!!][FEATURE] Dispatch extbase request through middleware stack

Alexander Schnitzler CR 0 V -1 Expert +1185 −34 updated 11/09/26, 19:54

Commit message

tbw

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 25

Show 5 more files

Review log 45

  1. Alexander Schnitzler uploaded patch set 1 10/05/25, 19:04

  2. Alexander Schnitzler commented on patch set 1 10/05/25, 19:06

    @benni@typo3.org @lolli@schwarzbu.ch FYI
  3. core-ci voted on patch set 1 V -1 10/05/25, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86041

  4. Alexander Schnitzler commented on patch set 1 10/06/25, 10:53

    Unresolved

    This patch is a POV which proves that it's quite straightforward to implement a middleware stack in Extbase. What I don't like about the current state but something that can't be solved easily, is adding more information/objects to the request object. Dissolving this is hard to achieve though. Actually, we currently only need the Arguments object and the Controller itself to be passed along. Those could be part of the ExtbaseRequestParameters attribute or it could be their own attributes on the request. Regarding the migration strategy: We could very well keep the ActionController as is and make the middleware-stack opt in for one version. Changes to the ActionController would then be done twice but it's still the easiest migration path IF we don't want it to be breaking from one version to another. Most parts involved here are internal but even then I know tons of projects that overwrite methods of the ActionController to add fixes or features that cannot be accomplished otherwise. Some technical detail I currently dislike but something I need is the enhancement of the ControllerInterface to have a public api for all controllers. I guess I would leave that interface as is and introduce several new ones for each functionality. Like one for the view releated stuff, ViewAwareInterface or whatever, one for the initialization logic and one for the error handling. Extbase could later still provide an ActionController implementing all Interfaces for full compatibility but users would also be able to create plain Controller classes that may or may not implement interfaces depending on their needs.
  5. Alexander Schnitzler abandoned the change 11/09/26, 19:54