Review main Merged

90912[BUGFIX] Skip nonce substitution when previous nonce is absent

Oliver Hader CR +2 V +2 Normal +91 −1 updated 10/07/25, 11:31

Commit message

During nonce substitution the code used to increment the nonce
consumption counter even when the expected nonce was not found
in the input content or was not different to the substitute.
This caused the counter to drift and eventually produce an
invalid nonce state.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Oliver Hader uploaded patch set 1 10/06/25, 15:12

  2. core-ci voted on patch set 1 V +1 10/06/25, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86077

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 10/06/25, 21:16

  4. Oliver Hader marked it work in progress 10/07/25, 08:02

  5. Oliver Hader uploaded patch set 2 CR +1 V +1 10/07/25, 08:14

  6. Oliver Hader marked it ready for review 10/07/25, 08:14

  7. core-ci voted on patch set 2 V +1 10/07/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86133

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 10/07/25, 08:37

  9. Markus Klein voted on patch set 2 CR +1 V +1 10/07/25, 10:47

  10. Oliver Hader commented on patch set 2 CR +2 V +2 10/07/25, 11:31

    Thx folks 😊
  11. Oliver Hader merged patch set 3 10/07/25, 11:31