90914[TASK] Update php-cs-fixer to version 3.88.2
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1821
-
Chris Müller uploaded patch set 1 10/06/25, 15:31
-
core-ci voted on patch set 1 V +1 10/06/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86079
-
Oliver Klee voted on patch set 1 CR +1 V +1 10/06/25, 18:29
-
Garvin Hicking voted on patch set 1 CR +1 V +1 10/06/25, 21:12
-
Stefan Bürk updated the commit message in patch set 2
CR +1V +110/06/25, 21:22 -
Stefan Bürk commented on patch set 2 10/06/25, 21:24
What is the reason using `--no-update` and a dedicated update call instead of using simply a single `composer require --dev ...` for the package ? (Eventually with -w/-W) -
core-ci voted on patch set 2 V +1 10/06/25, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86104
-
Chris Müller commented on patch set 2 10/07/25, 04:28
Reply
Because the other two transitive dependencies must be also updated. A "-W" would update more than those two transitive packages. -
Garvin Hicking voted on patch set 2 CR +1 V +1 10/07/25, 04:47
-
Oliver Klee voted on patch set 2 CR +1 V +1 10/07/25, 13:50
-
Garvin Hicking uploaded patch set 3
CR +1V +110/07/25, 15:07Resolve merge conflict -
Garvin Hicking voted on patch set 3 CR +1 V +1 10/07/25, 15:07
-
core-ci voted on patch set 3 V +1 10/07/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86166
-
Oliver Klee voted on patch set 3 CR +1 10/07/25, 15:16
-
Stefan Bürk voted on patch set 3 CR -1 10/10/25, 07:25
-
Stefan Bürk commented on patch set 3 10/10/25, 07:55
Pushed the backports, 13.4 seems okay but regarding 12.4: * 12.4 requires more transient packages to be updated (see backport commit message) * 12.4 finds cgl issues which needs to be applied So keeping the -1 for now as we need to review & vote the backports and decide how to deal with 12.4 and if we take that. -
Chris Müller commented on patch set 3 10/10/25, 08:36
Reply
Thanks, will look into it later. -
Stefan Bürk voted on patch set 3 CR +2 V +2 10/10/25, 10:22
-
Stefan Bürk commented on patch set 3 10/10/25, 10:22
Reply
Done -
Stefan Bürk commented on patch set 3 10/10/25, 10:22
Reply
Done -
Stefan Bürk merged patch set 4 10/10/25, 10:22