90915[TASK] Refine CSP Directive and SourceKeyword cases
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1620
-
Oliver Hader uploaded patch set 1 10/06/25, 16:43
-
core-ci voted on patch set 1 V +1 10/06/25, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86088
-
Garvin Hicking commented on patch set 1 10/06/25, 17:09
Since this would be public API (right?) and doesn't have a ReST file, could you add some more info to this so that we can add it to docs? Or would you maybe create a Docs PR when it gets merged? -
Oliver Hader commented on patch set 1 10/06/25, 18:58
Reply
You're just referring to `Directive::getFamily()`, correct? If it's too confusing, I'm fine with dropping that change and just use it inline all the time when needed. -
Garvin Hicking commented on patch set 1 10/06/25, 20:11
Reply
Yes - I thought since it is public it would/should be usable by third parties, but then it would need some explanation. If you're using it as a helper, maybe declare that single method as `@internal`? I do see it can't be made protected there. (I'm just commenting from a "public API documentation devil's advocate" point of view here) -
Oliver Hader marked it work in progress 10/07/25, 07:16
-
Oliver Hader uploaded patch set 2
V +110/07/25, 11:38 -
Oliver Hader marked it ready for review 10/07/25, 11:38
-
Oliver Hader commented on patch set 2 10/07/25, 11:42
Reply
I just marked the new public methods as `@internal` - those are supposed to be used by other core classes and the code fits best with these two classes (`Directive` and `SourceKeyword`) - instead of cluttering other classes with private constants basically doing all the same. I'm not sure (yet) whether those methods would be useful in custom code and whether it's required or helpful to add documentation RST files for each of these PHP methods. -
core-ci voted on patch set 2 V +1 10/07/25, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86150
-
Garvin Hicking commented on patch set 2 10/07/25, 12:12
Reply
Thanks, I consider that explained and solved like this. (Could not review/test/understand this, so I can't vote on this atm, not because I disagree) -
Oliver Hader rebased onto patch set 3
V +110/07/25, 19:16 -
core-ci voted on patch set 3 V +1 10/07/25, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86179
-
Oliver Hader commented on patch set 3 10/07/25, 19:45
Reply
Thanks for your feedback & that's totally fine. I admin, the scope of these changes cannot be determined without having the actual use cases. I reworked https://review.typo3.org/c/Packages/TYPO3.CMS/+/90814/7, which is part of the relation chain. -
Oliver Hader rebased onto patch set 4
V +110/08/25, 13:53 -
core-ci voted on patch set 4 V +1 10/08/25, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86234
-
Benni Mack voted on patch set 4 CR +1 V +1 10/09/25, 13:53
-
Garvin Hicking voted on patch set 4 CR +1 V +1 10/09/25, 15:35
-
Oliver Hader voted on patch set 4 CR +2 V +2 10/09/25, 18:24
-
Oliver Hader merged patch set 5 10/09/25, 18:24