Review main Merged

90918[TASK] Enable EnvironmentStatusReport for CLI

Garvin Hicking CR +2 V +2 Easy +21 −9 updated 03/04/26, 08:40

Commit message

Having the EnvironmentStatusReport disabled for CLI
makes the report scheduler task useless.

This patch allows to utilize the extended checks.

An important differentiation is that the environment
in CLI can be different from the Web configuration,
and certain variables are not available in CLI context
($_SERVER mostly).

This patch excludes these specific checks, and
should catch all places where this superglobal is accessed.

Additionally, to make recipients of the CLI-context based
report aware of possible differences between PHP configuration
on CLI and web context, a small disclaimer is added to
the email.

The new language service system has been utilized in the
places this touches.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Rozbeh Chiryai Sharahi +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Rozbeh Chiryai Sharahi +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 3450

Show 1525 earlier messages
  1. Garvin Hicking uploaded patch set 1 10/06/25, 20:45

  2. core-ci voted on patch set 1 V +1 10/06/25, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86099

  3. Garvin Hicking updated the commit message in patch set 2 V +1 10/07/25, 07:06

  4. core-ci voted on patch set 2 V +1 10/07/25, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86128

  5. Garvin Hicking uploaded patch set 3 V +1 10/10/25, 09:52

  6. core-ci voted on patch set 3 V +1 10/10/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86379

  7. Benjamin Franzke updated the commit message in patch set 4 V +1 10/10/25, 11:25

  8. core-ci voted on patch set 4 V +1 10/10/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86397

  9. Chris Müller updated the commit message in patch set 5 V +1 10/10/25, 12:51

  10. core-ci voted on patch set 5 V +1 10/10/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86399

  11. Sven Liebert voted on patch set 5 CR +1 10/22/25, 18:41

  12. Sven Liebert voted on patch set 5 V +1 10/22/25, 18:44

  13. Jochen Roth commented on patch set 5 10/22/25, 19:27

    locallang_reports.xlf:265

    > When the report is generated from CLI (Command Line Interface) context, I'd suggest: > This report was generated from CLI (Command Line Interface) context, IMHO, "When the report..." leaves room for interpretation, while we already know it was generated via CLI
  14. Sven Liebert rebased onto patch set 6 CR +1 V +1 10/22/25, 19:33

  15. Sven Liebert commented on patch set 6 CR +1 V +1 10/22/25, 19:37

    Sorry some weired happend here when changing an other patch? I some kind of created a relation chain. That was not intended :O
  16. Sven Liebert rebased onto patch set 7 CR +1 V +1 10/22/25, 19:42

  17. core-ci voted on patch set 6 V +1 10/22/25, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87293

  18. core-ci voted on patch set 7 V +1 10/22/25, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87296

  19. Stefan Bürk uploaded patch set 8 10/22/25, 19:58

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  20. Stefan Bürk uploaded patch set 9 10/22/25, 20:04

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  21. core-ci voted on patch set 8 V +1 10/22/25, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87301

  22. core-ci voted on patch set 9 V +1 10/22/25, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87303

  23. Garvin Hicking commented on patch set 10 V +1 10/23/25, 06:30

    Published edit on patch set 9.
  24. Garvin Hicking commented on patch set 10 10/23/25, 06:30

    locallang_reports.xlf:265 Reply

    Yes, that makes it clearer, thank you!
  25. core-ci voted on patch set 10 V +1 10/23/25, 06:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87377

  1. Jochen Roth voted on patch set 10 CR +1 V +1 10/23/25, 07:15

  2. Sven Liebert voted on patch set 10 CR +1 V +1 10/23/25, 07:21

  3. Garvin Hicking commented on patch set 10 CR -1 10/23/25, 14:05

    blocking this so @ben@bnf.dev can give feedback. this was meant to keep the issue afloat, not sure we can/should do it like this (personally, I see benefit in this for v13)
  4. Garvin Hicking uploaded patch set 11 CR +1 V +1 01/14/26, 20:25

  5. core-ci voted on patch set 11 V +1 01/14/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93476

  6. Garvin Hicking commented on patch set 11 02/27/26, 21:38

    Unblocking this so maybe I can gather more votes/feedback :)
  7. Garvin Hicking commented on patch set 11 02/27/26, 21:38

    Reply

    Done
  8. Oliver Klee updated the commit message in patch set 12 V +1 02/28/26, 08:38

  9. Oliver Klee commented on patch set 12 02/28/26, 08:39

    locallang_reports.xlf:265

    ```suggestion <source>This report was generated from the Command Line Interface (CLI) context. The PHP settings and modules might differ from the ones defined for the webserver process, for example when using a different php.ini file. In case of problems, always compare the report with the one generated via the backend report module.</source> ```
  10. core-ci voted on patch set 12 V -1 02/28/26, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97012

  11. Oliver Klee rebased onto patch set 13 V -1 02/28/26, 09:10

  12. Garvin Hicking commented on patch set 14 02/28/26, 09:11

    Published edit on patch set 13.
  13. Garvin Hicking uploaded patch set 15 02/28/26, 09:20

  14. core-ci voted on patch set 15 V +1 02/28/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97016

  15. core-ci voted on patch set 13 V +1 02/28/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97013

  16. core-ci voted on patch set 14 V -1 02/28/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97014

  17. core-ci voted on patch set 14 V +1 02/28/26, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97014

  18. Oliver Klee commented on patch set 15 CR +1 02/28/26, 11:47

    locallang_reports.xlf:265 Reply

    Done
  19. Georg Ringer commented on patch set 15 03/02/26, 17:39

    I would more like to see that in main only
  20. Garvin Hicking commented on patch set 15 03/02/26, 19:34

    Reply

    This affects a few of our projects in which we cannot use the cronjob. Please let's fix this in v13.

    locallang_reports.xlf:265 Reply

    Fix applied.
  21. Georg Ringer voted on patch set 15 CR +1 V +1 03/03/26, 16:18

  22. Simon Schaufelberger voted on patch set 15 CR +1 V +1 03/03/26, 17:51

  23. Rozbeh Chiryai Sharahi commented on patch set 15 CR +1 V +1 03/03/26, 22:38

    In CLI the status report is successfully created. <3
  24. Garvin Hicking voted on patch set 15 CR +2 V +2 03/04/26, 05:42

  25. Garvin Hicking merged patch set 16 03/04/26, 08:40