Review main Merged

90936[BUGFIX] Show semantic labels in color picker and merge value picker

Benjamin Franzke CR +2 V +2 Normal +56 −48 updated 01/28/26, 15:29

Commit message

The color palette support added in #101843 prepared the
configuration format to support labels once they
are supported upstream in alwan. Since labels can now
be supplied, we use this to show accessible labels for
color swatches and merge the existing, inaccessible
valuePicker implementation into the alwan color swatches.

Label support has been added upstream via:
https://github.com/sefianecho/alwan/pull/22
which is why alwan is updated to v2.3

Executed commands:

  npm install --save alwan@^2.3
  npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 1319

  1. Benjamin Franzke uploaded patch set 1 10/07/25, 06:46

  2. core-ci voted on patch set 1 V -1 10/07/25, 07:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86127

  3. Benjamin Franzke uploaded patch set 2 V -1 10/07/25, 07:25

  4. Benjamin Franzke uploaded patch set 3 10/07/25, 07:32

  5. core-ci voted on patch set 2 V -1 10/07/25, 07:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86130

  6. core-ci voted on patch set 3 V +1 10/07/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86131

  7. Benjamin Franzke uploaded patch set 4 V +1 10/16/25, 06:22

  8. core-ci voted on patch set 4 V -1 10/16/25, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86782

  9. Benjamin Franzke uploaded patch set 5 V -1 10/16/25, 09:06

  10. core-ci voted on patch set 5 V +1 10/16/25, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86796

  11. Benni Mack voted on patch set 5 CR +1 V +1 10/16/25, 15:05

  12. Benni Mack voted on patch set 5 V 0 10/16/25, 15:05

  13. Benni Mack voted on patch set 5 V +1 10/16/25, 15:38

  14. Garvin Hicking uploaded patch set 6 CR +1 V +1 01/24/26, 23:09

  15. core-ci voted on patch set 6 V +1 01/24/26, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94273

  16. Garvin Hicking commented on patch set 6 CR +1 V +1 01/25/26, 00:11

    Would be nice to get this one in
  17. Benni Mack voted on patch set 6 CR +1 V +1 01/25/26, 11:04

  18. Benjamin Franzke commented on patch set 6 CR +2 V +2 01/28/26, 15:29

    Reply

    Thanks for taking care of the rebase.
  19. Benjamin Franzke merged patch set 7 01/28/26, 15:29