Review 13.4 Merged

90937[BUGFIX] Skip nonce substitution when previous nonce is absent

Oliver Hader CR +2 V +2 Normal +91 −1 updated 10/07/25, 11:31

Commit message

During nonce substitution the code used to increment the nonce
consumption counter even when the expected nonce was not found
in the input content or was not different to the substitute.
This caused the counter to drift and eventually produce an
invalid nonce state.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 10/07/25, 08:16

  2. core-ci voted on patch set 1 V +1 10/07/25, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86134

  3. Oliver Hader voted on patch set 1 CR +2 V +2 10/07/25, 11:31

  4. Oliver Hader merged patch set 2 10/07/25, 11:31