90949[BUGFIX] Properly resolve resource modes in Stream::isWritable()
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Thomas Hohn +1
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Thomas Hohn +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1011
-
Oliver Hader uploaded patch set 1 10/08/25, 09:13
-
Markus Klein commented on patch set 1 10/08/25, 09:19
can we please enhance the forge issue with some example, on where this failed until now? -
core-ci voted on patch set 1 V +1 10/08/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86213
-
Benni Mack voted on patch set 1 CR +1 V +1 10/08/25, 09:51
-
Garvin Hicking voted on patch set 1 CR +1 V +1 10/08/25, 09:55
-
Oliver Hader commented on patch set 1 10/08/25, 09:56
Reply
That's why I added the test cases - those would fail having the `Stream` subject unpatched. -
Oliver Hader commented on patch set 1 10/08/25, 10:01
Reply
I've added an example to the Forge issue. -
Thomas Hohn voted on patch set 1 CR +1 V +1 10/08/25, 10:07
-
Oliver Hader commented on patch set 1 CR +2 V +2 10/08/25, 10:10
Thx folks 😊 -
Oliver Hader merged patch set 2 10/08/25, 10:11
-
Markus Klein commented on patch set 2 10/08/25, 10:14
Reply
thx!