Review main Merged

90953[BUGFIX] Use correct values for aria-expanded

Georg Ringer CR +2 V +2 Easy +2 −2 updated 10/09/25, 08:32

Commit message

Tree items must be set to `true` or `false` and not to
`1` or `0`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 10/08/25, 14:36

  2. Georg Ringer commented on patch set 1 10/08/25, 14:37

    This change is ready for review.
  3. Benjamin Franzke commented on patch set 1 CR +1 V +1 10/08/25, 14:40

    Btw, there is more than that, our `aria-owns` attribute is wrong as well, see following patch where I'm fixing `aria-expanded` as well and additionally `aria-owns`: > 90952: [WIP][BUGFIX] Fix aria attributes in page tree | https://review.typo3.org/c/Packages/TYPO3.CMS/+/90952 Anyway, I'm fine with fixing aria-expanded with this patch.
  4. core-ci voted on patch set 1 V +1 10/08/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86237

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 10/08/25, 15:19

  6. Christian Kuhn voted on patch set 1 CR +1 V +1 10/08/25, 22:52

  7. Benjamin Franzke voted on patch set 1 CR +2 V +2 10/09/25, 08:04

  8. Benjamin Franzke merged patch set 2 10/09/25, 08:32