Review main Merged

90956[BUGFIX] Add default data structure for sys_file_storage

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/08/25, 22:21

Commit message

The sys_file_storage table defines a default
record type "0" with the field "configuration"
of TCA type "flex". This record type is used
as basis by custom drivers, registered via
`DriverRegistry->addDriversToTCA()`.

However, when checking the static TCA there
is a record type with a flex field while
it's data structure is empty. This is not
allowed (unless intercepted by an PSR-14
event - which is not the case here).

Therefore, the field needs to define a
default data structure to prevent a
`InvalidTcaException`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/08/25, 16:06

  2. core-ci voted on patch set 1 V +1 10/08/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86240

  3. Benni Mack voted on patch set 1 CR +1 V +1 10/08/25, 16:47

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 10/08/25, 19:15

  5. Markus Klein voted on patch set 1 CR +1 V +1 10/08/25, 19:16

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 10/08/25, 22:21

  7. Oli Bartsch merged patch set 2 10/08/25, 22:21