Review main Abandoned Breaking

90957[WIP][!!!][TASK] Disable converting values by default in `Connection`

Stefan Bürk CR 0 V 0 Normal +78 −54 updated 11/11/25, 17:59

Commit message

-----------------------------------------------------------------
> Note: POC for now - it seams that this has a more broader
> impact and may not be reasonable to remove it easily.
-----------------------------------------------------------------
@todo Add breaking rst file.
-----------------------------------------------------------------

With #99062 native json field support has been introduced
along with automatic value encoding using following methods:

* `Connection::insert()`
* `Connection::update()`
* `Connection::bulkInsert()`

Meanwhile it turned out, that this is not really optimal
on these more lowerlevel API methods, for example using
Extbase ORM reported in #106638.

Removing the automatic type conversion is not reliable,
as this does not only impact problematic json encoding
and would hit projects or extension using the connection
methods and for example providing `\DateTimeImmutable`
or `\DateTime` objects as values, which gained support
by implementing custom types with #102479.

TYPO3 Core should not rely on the automatic conversion
and introduced argument `$convertValueToDatabaseValue`
with #106638 is switched from default `true` to `false`,
which means that calling code needs to provide `true` as
argument to keep automatic value conversion in place.

Be aware that `DataHandler` no longer `json_encodes()`
values for fields with database type `json` not using
`TCAtype=json`.

Adding missing Extbase ORM json support needs to be handle
proper `json_encode()/json_decode()` directly and not part
of this change.

This change requires a testing-framework change, which is
added from PR branch for testing purpose and needs to be
merged first and can be added either as update with this
change or as a pre-change already.

Used command(s):

  Build/Scripts/runTests.sh -s composer -- require \
    --dev typo3/testing-framework:'dev-stefan-3'

[1] https://github.com/TYPO3/testing-framework/pull/687

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 3

Files 7

Review log 1528

Show 3 earlier messages
  1. Stefan Bürk uploaded patch set 1 10/08/25, 16:18

  2. Stefan Bürk marked it work in progress 10/08/25, 16:18

  3. Stefan Bürk rebased onto patch set 2 10/08/25, 16:30

  1. core-ci voted on patch set 1 V -1 10/08/25, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86243

  2. core-ci voted on patch set 2 V -1 10/08/25, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86245

  3. Stefan Bürk uploaded patch set 3 V -1 10/08/25, 17:58

  4. Stefan Bürk updated the commit message in patch set 4 10/08/25, 17:58

  5. Stefan Bürk uploaded patch set 5 10/08/25, 18:02

  6. Stefan Bürk uploaded patch set 6 10/08/25, 18:03

  7. core-ci voted on patch set 3 V -1 10/08/25, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86247

  8. core-ci voted on patch set 4 V -1 10/08/25, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86248

  9. core-ci voted on patch set 5 V -1 10/08/25, 18:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86249

  10. core-ci voted on patch set 6 V -1 10/08/25, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86250

  11. Stefan Bürk uploaded patch set 7 V -1 10/08/25, 18:22

  12. core-ci voted on patch set 7 V +1 10/08/25, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86251

  13. Stefan Bürk uploaded patch set 8 V +1 10/08/25, 18:40

  14. core-ci voted on patch set 8 V +1 10/08/25, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86255

  15. Stefan Bürk uploaded patch set 9 V +1 10/10/25, 17:28

  16. core-ci voted on patch set 9 V +1 10/10/25, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86430

  17. Stefan Bürk uploaded patch set 10 V +1 10/11/25, 16:12

  18. core-ci voted on patch set 10 V +1 10/11/25, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86470

  19. Stefan Bürk rebased onto patch set 11 V +1 10/13/25, 10:04

  20. core-ci voted on patch set 11 V +1 10/13/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86527

  21. Stefan Bürk rebased onto patch set 12 V +1 10/16/25, 07:45

  22. core-ci voted on patch set 12 V +1 10/16/25, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86790

  23. Stefan Bürk uploaded patch set 13 V +1 11/10/25, 12:30

  24. core-ci voted on patch set 13 V +1 11/10/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88843

  25. Stefan Bürk abandoned the change 11/11/25, 17:59

    not required anymore, parent change has been refactored not needed a breaking change anymore.