Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

90968[WIP][TASK] Replace lazy services with \Closure or ServiceLocators

Benjamin Franzke CR 0 V 0 Normal +65 −61 updated 10/30/25, 08:48

Commit message

…to retain PHP8.2 compatibility when DI cache
is generated with PHP 8.4 CLI, see:
https://typo3.slack.com/archives/C03AM9R17/p1759968091221549

This code does not look nice and we should and will
look for replacements, but this is actually intended
to fix PHP 8.2-8.4 compat without changing application logic.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/68/90968/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/68/90968/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Files 7

Review log 47

  1. Benjamin Franzke uploaded patch set 1 10/09/25, 10:18

  2. core-ci voted on patch set 1 V +1 10/09/25, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86288

  3. Benjamin Franzke uploaded patch set 2 V +1 10/09/25, 10:36

  4. core-ci voted on patch set 2 V -1 10/09/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86289

  5. Benjamin Franzke uploaded patch set 3 V -1 10/09/25, 10:45

  6. core-ci voted on patch set 3 V +1 10/09/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86290

  7. Benjamin Franzke marked it work in progress 10/30/25, 08:48