90978[WIP][POC] extbase json support
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 13
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/90978/13 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/90978/13 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 5
-
90978 [WIP][POC] extbase json support This change
- main 91026[WIP][BUGFIX] Let custom `TypeInterface` handle convertion on their own
- main 91004[WIP][BUGFIX] Avoid assuming custom property type is a relation
- main 94190[WIP][BUGFIX] Restrict DataHandler json encoding only to TCAtype=json
-
main
89293[BUGFIX] Honor parameter types in writable Connection methods
The chain has patch set 31 of 40, the changes above it need a rebase.
Files 29
- typo3/sysext/core/Classes/Type/AbstractJsonType.php4new+110 −0
- typo3/sysext/core/Classes/Type/JsonArray.php1new+139 −0
- typo3/sysext/core/Classes/Type/JsonValue.php1new+59 −0
- typo3/sysext/core/Tests/Unit/Type/JsonArrayTest.phpnew+119 −0
- typo3/sysext/core/Tests/Unit/Type/JsonValueTest.phpnew+86 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Model/ExampleCustomJsonProperty.phpnew+80 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Model/ExampleJsonArrayProperty.phpnew+80 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Model/ExampleJsonValueProperty.phpnew+80 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Repository/ExampleCustomJsonPropertyRepository.phpnew+34 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Repository/ExampleJsonArrayPropertyRepository.phpnew+34 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Domain/Repository/ExampleJsonValuePropertyRepository.phpnew+34 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Classes/Persistance/Type/CustomJsonType.phpnew+52 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Configuration/Extbase/Persistence/Classes.phpnew+28 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/Configuration/TCA/tx_testjsonfields_domain_model_example.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_json_fields/ext_tables.sql+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonArray.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_boolFalse.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_boolTrue.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_floatvalue.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_integervalue.csvnew+3 −0
Show 9 more files
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_nestedArrayStructure.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_null.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/DataSet/newModelIsPersistedLikeExpected_JsonValue_stringvalue.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/CustomJsonTypeTestImport.csvnew+7 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/JsonArrayTestImport.csvnew+9 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/JsonValueTestImport.csvnew+9 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/CustomJsonTypeTest.phpnew+122 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/JsonArrayTest.phpnew+226 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/JsonValueTest.phpnew+314 −0
Review log 1427
Show 12 earlier messages
-
Stefan Bürk uploaded patch set 1 10/09/25, 16:09
-
core-ci voted on patch set 1 V -1 10/09/25, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86324
-
Stefan Bürk uploaded patch set 2
V -110/09/25, 16:42 -
core-ci voted on patch set 2 V +1 10/09/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86328
-
Stefan Bürk uploaded patch set 3
V +110/10/25, 17:28 -
core-ci voted on patch set 3 V -1 10/10/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86431
-
Stefan Bürk uploaded patch set 4
V -110/11/25, 16:12 -
core-ci voted on patch set 4 V -1 10/11/25, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86472
-
Stefan Bürk uploaded patch set 5
V -110/12/25, 11:19 -
core-ci voted on patch set 5 V +1 10/12/25, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86491
-
Stefan Bürk uploaded patch set 6
V +110/13/25, 10:04 -
core-ci voted on patch set 6 V -1 10/13/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86529
-
Stefan Bürk rebased onto patch set 7
V -110/13/25, 10:25 -
core-ci voted on patch set 7 V -1 10/13/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86532
-
Stefan Bürk uploaded patch set 8
V -110/13/25, 10:51 -
core-ci voted on patch set 8 V +1 10/13/25, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86535
-
Stefan Bürk uploaded patch set 9
V +110/13/25, 15:05 -
core-ci voted on patch set 9 V -1 10/13/25, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86555
-
Stefan Bürk uploaded patch set 10
V -110/13/25, 16:35 -
core-ci voted on patch set 10 V +1 10/13/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86571
-
Stefan Froemken commented on patch set 10 10/14/25, 08:55
AbstractJsonType.php:42UnresolvedNice to have: Empty line between early return and rest of code ;-)AbstractJsonType.php:50UnresolvedReturn value is "mixed" in classAbstractJsonType.php:90UnresolvedNice. No default here, but can be set later, if emptyJsonArray.php:136UnresolvedAha...you need 26 minutes to write this class 😄JsonValue.php:32UnresolvedCan we use something different than "public" here? -
Stefan Bürk rebased onto patch set 11
V +110/16/25, 07:45 -
core-ci voted on patch set 11 V +1 10/16/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86793
-
Stefan Bürk rebased onto patch set 12
V +111/10/25, 12:30 -
core-ci voted on patch set 12 V +1 11/10/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88846
-
Stefan Bürk rebased onto patch set 13
V +105/28/26, 14:01 -
core-ci voted on patch set 13 V -1 05/28/26, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102550
AbstractJsonType.php:33Unresolved