Review main Work in progress Stale

90978[WIP][POC] extbase json support

Stefan Bürk CR 0 V -1 Expert +1649 −1 updated 05/28/26, 14:39

Commit message

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 13
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/90978/13 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/78/90978/13 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 5

  1. 90978 [WIP][POC] extbase json support This change

  2. main 91026[WIP][BUGFIX] Let custom `TypeInterface` handle convertion on their own This change is based on it Work in progress Stefan Bürk CR 0 V 0 → 14.3, 13.4 Easy +5 −4
  3. main 91004[WIP][BUGFIX] Avoid assuming custom property type is a relation This change is based on it Abandoned Stefan Bürk CR 0 V 0 → 14.3, 13.4 Easy +21 −2
  4. main 94190[WIP][BUGFIX] Restrict DataHandler json encoding only to TCAtype=json This change is based on it Work in progress Stefan Bürk CR 0 V 0 → 14.3, 13.4 Easy +34 −2
  5. main 89293[BUGFIX] Honor parameter types in writable Connection methods This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3 Hard +385 −22

    The chain has patch set 31 of 40, the changes above it need a rebase.

Files 29

Show 9 more files

Review log 1427

Show 12 earlier messages
  1. Stefan Bürk uploaded patch set 1 10/09/25, 16:09

  2. core-ci voted on patch set 1 V -1 10/09/25, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86324

  1. Stefan Bürk uploaded patch set 2 V -1 10/09/25, 16:42

  2. core-ci voted on patch set 2 V +1 10/09/25, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86328

  3. Stefan Bürk uploaded patch set 3 V +1 10/10/25, 17:28

  4. core-ci voted on patch set 3 V -1 10/10/25, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86431

  5. Stefan Bürk uploaded patch set 4 V -1 10/11/25, 16:12

  6. core-ci voted on patch set 4 V -1 10/11/25, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86472

  7. Stefan Bürk uploaded patch set 5 V -1 10/12/25, 11:19

  8. core-ci voted on patch set 5 V +1 10/12/25, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86491

  9. Stefan Bürk uploaded patch set 6 V +1 10/13/25, 10:04

  10. core-ci voted on patch set 6 V -1 10/13/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86529

  11. Stefan Bürk rebased onto patch set 7 V -1 10/13/25, 10:25

  12. core-ci voted on patch set 7 V -1 10/13/25, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86532

  13. Stefan Bürk uploaded patch set 8 V -1 10/13/25, 10:51

  14. core-ci voted on patch set 8 V +1 10/13/25, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86535

  15. Stefan Bürk uploaded patch set 9 V +1 10/13/25, 15:05

  16. core-ci voted on patch set 9 V -1 10/13/25, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86555

  17. Stefan Bürk uploaded patch set 10 V -1 10/13/25, 16:35

  18. core-ci voted on patch set 10 V +1 10/13/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86571

  19. Stefan Froemken commented on patch set 10 10/14/25, 08:55

    AbstractJsonType.php:33 Unresolved

    Will you keep "public" here?

    AbstractJsonType.php:42 Unresolved

    Nice to have: Empty line between early return and rest of code ;-)

    AbstractJsonType.php:50 Unresolved

    Return value is "mixed" in class

    AbstractJsonType.php:90 Unresolved

    Nice. No default here, but can be set later, if empty

    JsonArray.php:136 Unresolved

    Aha...you need 26 minutes to write this class 😄

    JsonValue.php:32 Unresolved

    Can we use something different than "public" here?
  20. Stefan Bürk rebased onto patch set 11 V +1 10/16/25, 07:45

  21. core-ci voted on patch set 11 V +1 10/16/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86793

  22. Stefan Bürk rebased onto patch set 12 V +1 11/10/25, 12:30

  23. core-ci voted on patch set 12 V +1 11/10/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88846

  24. Stefan Bürk rebased onto patch set 13 V +1 05/28/26, 14:01

  25. core-ci voted on patch set 13 V -1 05/28/26, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102550