Review 13.4 Merged

90979[TASK] Refine CSP Directive and SourceKeyword cases

Oliver Hader CR +2 V +2 Normal +144 −9 updated 10/09/25, 18:25

Commit message

* added Directive::getFamily() method
  - Directive::ScriptSrc->getFamily() now includes
    ScriptScr, ScriptSrcAttr, ScriptSrcElem
  - Directive::StyleSrc->getFamily() now includes
    StyleSrc, StyleSrcAttr, StyleSrcElem
* added additional SourceKeyword restrictions
  - unsafeHashes allowed in DefaultSrc & ScriptSrc/StyleSrc families
  - unsafeInline allowed in DefaultSrc & ScriptSrc/StyleSrc families
  - nonceProxy allowed in DefaultSrc & ScriptSrc/StyleSrc families,
    except their Attr aspects
* added SourceKeyword::getApplicableDirectives for resolving the
  Directive restrictions mentioned in the previous section

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 10/09/25, 17:49

  2. core-ci voted on patch set 1 V +1 10/09/25, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86330

  3. Oliver Hader voted on patch set 1 CR +2 V +2 10/09/25, 18:25

  4. Oliver Hader merged patch set 2 10/09/25, 18:25