Review 13.4 Merged

90981[TASK] Allow scalar values in \TYPO3\CMS\Core\Type\Map

Oliver Hader CR +2 V +2 Normal +102 −55 updated 10/09/25, 18:27

Commit message

This change allows to use scalar in addition to using only
object values as keys in \TYPO3\CMS\Core\Type\Map.

> $aObject = new \stdClass();
> $bArray = ['b' => 'Array'];
> $cString = 'cString';
>
> $map = new \TYPO3\CMS\Core\Type\Map();
> $map[$aObject] = 'a';
> $map[$bArray] = 'b';
> $map[$cString] = 'c';

The internal \SplObjectStorage wrapper was dropped, since
it did only support object values as keys.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 10/09/25, 17:51

  2. core-ci voted on patch set 1 V +1 10/09/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86332

  3. Oliver Hader voted on patch set 1 CR +2 V +2 10/09/25, 18:26

  4. Oliver Hader merged patch set 2 10/09/25, 18:27