Review 12.4 Merged

90987[TASK] Update php-cs-fixer to version 3.88.2

Stefan Bürk CR +2 V +2 Hard +270 −155 updated 10/10/25, 10:23

Commit message

Version 3.88.0 of php-cs-fixer renamed the rule sets to adhere to
MAJORxMINOR instead of MAJORMINOR and MAJOR.MINOR.

The previously used "@PER-CS1.0" rule set is now deprecated in favor of
"@PER-CS1x0".

When running php-cs-fixer with version 3.88 this also avoids the
following deprecation message:

"Rule set "@PER-CS1.0" is deprecated. Use "@PER-CS1x0" instead."

Additionally, fixes provided by php-cs-fixer are applied, which
boils down to two kind of changes:

* Missing visibility for `CPP`, adding `public` where none provided.
* Modify order in case readonly and visibility is given to have the
  visibility first: `public readonly string $property`

Executed commands:

    composer --dev --no-update require friendsofphp/php-cs-fixer:^3.88.2
    composer --dev update \
        friendsofphp/php-cs-fixer \
        fidry/cpu-core-counter \
        react/promise \
        react/child-process \
        react/socket \
        react/stream \
        react/dns \
        symfony/console \
        symfony/event-dispatcher \
        symfony/filesystem \
        symfony/finder \
        symfony/options-resolver \
        symfony/process \
        symfony/stopwatch
    Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 45

  1. Stefan Bürk uploaded patch set 1 10/10/25, 07:53

  2. core-ci voted on patch set 1 V +1 10/10/25, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86364

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 10/10/25, 10:16

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 10/10/25, 10:23

  5. Stefan Bürk merged patch set 2 10/10/25, 10:23