90988[TASK] Hash `major.minor` PHP version into DI cache identifier
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Christian Kuhn +1
- Nikita Hovratov +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Christian Kuhn +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1823
-
Benjamin Franzke uploaded patch set 1 10/10/25, 08:14
-
Benjamin Franzke updated the commit message in patch set 2 10/10/25, 08:20
-
core-ci voted on patch set 1 V +1 10/10/25, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86365
-
Garvin Hicking commented on patch set 2 10/10/25, 08:29
I like this route; we could ship an Important.rst with it to raise awareness of mismatching PHP versions and the effect it can have on deploying warmed cachefiles. -
core-ci voted on patch set 2 V +1 10/10/25, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86367
-
Benjamin Franzke uploaded patch set 3
V +110/10/25, 10:18 -
Benjamin Franzke commented on patch set 3 10/10/25, 10:18
Reply
not easy to explain, but done (feel free to improve) -
Garvin Hicking commented on patch set 3 CR +1 V +1 10/10/25, 10:21
Reply
Great, no notes. Thanks! :) -
Benjamin Franzke uploaded patch set 4
CR +1V +110/10/25, 10:23 -
Nikita Hovratov voted on patch set 4 CR +1 10/10/25, 10:25
-
core-ci voted on patch set 3 V +1 10/10/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86382
-
Nikita Hovratov voted on patch set 4 V +1 10/10/25, 10:33
-
core-ci voted on patch set 4 V +1 10/10/25, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86383
-
Garvin Hicking commented on patch set 5
CR +1V +110/10/25, 11:23Published edit on patch set 4. -
Garvin Hicking voted on patch set 5 CR +1 V +1 10/10/25, 11:24
-
Nikita Hovratov voted on patch set 5 CR +1 V +1 10/10/25, 11:25
-
core-ci voted on patch set 5 V +1 10/10/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86396
-
Benni Mack voted on patch set 5 CR +1 V +1 10/10/25, 13:39
-
Oliver Hader voted on patch set 5 CR +1 10/10/25, 14:19
-
Christian Kuhn voted on patch set 5 CR +1 V +1 10/10/25, 15:20
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 10/10/25, 15:34
-
Benjamin Franzke merged patch set 6 10/10/25, 15:48
-
Lina Wolf commented on patch set 6 10/11/25, 06:21
Unresolved
This should also be mentioned in the commands helptext to not go unnoticed: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91009