Review main Merged

90991[TASK] Deprecate InfoboxViewHelper STATE_* constants

Oli Bartsch CR +2 V +2 Hard +307 −151 updated 10/11/25, 05:49

Commit message

The public constants STATE_NOTICE, STATE_INFO, STATE_OK,
STATE_WARNING, and STATE_ERROR in InfoboxViewHelper are
deprecated in favor of the ContextualFeedbackSeverity enum.

This change establishes a single source of truth for severity
levels across TYPO3 Core, improving type safety and maintainability.

The InfoboxViewHelper has been enhanced to accept the
ContextualFeedbackSeverity enum directly while maintaining
backwards compatibility with integer values. This provides
a clean migration path without requiring workarounds in
Fluid templates.

All usages across TYPO3 Core have been migrated to use the
enum, demonstrating the straightforward migration path                                                                                                                                                                             for extension authors.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 81

Show 61 more files

Review log 1418

  1. Oli Bartsch uploaded patch set 1 10/10/25, 09:01

  2. Mathias Brodala commented on patch set 1 10/10/25, 09:05

    Deprecation-107648-InfoboxViewHelperStateConstants.rst:54

    Shouldn't we promote using the enums directly instead of their backed values?
  3. Oli Bartsch uploaded patch set 2 10/10/25, 09:07

  4. core-ci voted on patch set 1 V +1 10/10/25, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86373

  5. core-ci voted on patch set 2 V +1 10/10/25, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86374

  6. Oli Bartsch uploaded patch set 3 V +1 10/10/25, 09:22

  7. Oli Bartsch commented on patch set 3 10/10/25, 09:22

    Deprecation-107648-InfoboxViewHelperStateConstants.rst:54 Reply

    Good point. Done.
  8. Mathias Brodala commented on patch set 3 10/10/25, 09:25

    The actual code should also use the actual enums as far as possible.

    PageLayoutController.php:352

    This should also be the actual enum instead of the backed value.
  9. Oli Bartsch uploaded patch set 4 10/10/25, 09:28

  10. Oli Bartsch commented on patch set 4 10/10/25, 09:28

    PageLayoutController.php:352 Reply

    Already pushed. 😊
  11. core-ci voted on patch set 3 V +1 10/10/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86375

  12. core-ci voted on patch set 4 V +1 10/10/25, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86376

  13. Mathias Brodala voted on patch set 4 CR +1 10/10/25, 09:36

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 10/10/25, 12:04

  15. Benni Mack voted on patch set 4 CR +1 V +1 10/10/25, 12:41

  16. Oli Bartsch voted on patch set 4 CR +2 V +2 10/10/25, 13:21

  17. Oli Bartsch merged patch set 5 10/10/25, 13:21

  18. Lina Wolf commented on patch set 5 10/11/25, 05:49