Review main Merged Breaking

90993[!!!][TASK] Remove random subpage option of doktype=shortcut

Benni Mack CR +2 V +2 Hard +148 −105 updated 10/13/25, 07:44

Commit message

The functionality of "Random subpage of current / selected page"
when choosing a page of type "shortcut" was removed
from TYPO3 Core.

It had little use and wasn't really "random" as the random
value was cached for pages that had links to this page,
as the links are resolved since TYPO3 v11 on page generation
and not during resolution.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1825

  1. Benni Mack uploaded patch set 1 10/10/25, 10:36

  2. Benni Mack updated the commit message in patch set 2 10/10/25, 10:41

  3. core-ci voted on patch set 2 V -1 10/10/25, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86388

  4. core-ci voted on patch set 1 V -1 10/10/25, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86387

  5. Benni Mack uploaded patch set 3 V -1 10/10/25, 12:57

  6. core-ci voted on patch set 3 V +1 10/10/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86400

  7. Benni Mack uploaded patch set 4 V +1 10/10/25, 13:35

  8. Benni Mack uploaded patch set 5 10/10/25, 13:36

  9. core-ci voted on patch set 4 V +1 10/10/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86407

  10. core-ci voted on patch set 5 V +1 10/10/25, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86409

  11. Oli Bartsch uploaded patch set 6 V +1 10/10/25, 14:18

  12. Oli Bartsch commented on patch set 6 V -1 10/10/25, 14:19

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:48

    This is not true. Default case is "selected page" which now fails => 404 error
  13. Garvin Hicking commented on patch set 6 10/10/25, 14:21

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:87

    PartiallyScanned or FullyScanned?
  14. core-ci voted on patch set 6 V +1 10/10/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86412

  15. Benni Mack commented on patch set 6 10/10/25, 14:38

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:48 Reply

    wdyt, upgrade wizard?
  16. Oli Bartsch uploaded patch set 7 V +1 10/10/25, 14:43

  17. Oli Bartsch commented on patch set 7 10/10/25, 14:44

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:48 Reply

    Check latest patchset. I updated to actually make the first subpage the default. However, would still fail if no subpage is available. However, random subpage would have not worked in that case either.

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:87 Reply

    Done
  18. core-ci voted on patch set 7 V +1 10/10/25, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86413

  19. Benni Mack commented on patch set 7 10/10/25, 15:25

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:48 Reply

    I think that's good!
  20. Benni Mack commented on patch set 7 10/10/25, 15:25

    Breaking-107654-RemoveRandomSubpageOptionOfDoktypeShortcut.rst:48 Reply

    Done
  21. Georg Ringer voted on patch set 7 CR +1 V +1 10/10/25, 15:39

  22. Jasmina Ließmann voted on patch set 7 CR +1 V +1 10/10/25, 16:16

  23. Simon Schaufelberger voted on patch set 7 CR +1 V +1 10/10/25, 18:30

  24. Benni Mack voted on patch set 7 CR +2 V +2 10/13/25, 07:44

  25. Benni Mack merged patch set 8 10/13/25, 07:44