90998[TASK] Avoid unintentional null values passed to TagBuilder
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Simon Praetorius uploaded patch set 1 10/10/25, 13:35
-
core-ci voted on patch set 1 V +1 10/10/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86408
-
Garvin Hicking voted on patch set 1 CR +1 V +1 10/10/25, 14:23
-
Oli Bartsch commented on patch set 1 10/10/25, 14:45
Do we know of further attributes where this is relevant? -
Christian Kuhn voted on patch set 1 CR +1 V +1 10/10/25, 15:19
-
Simon Praetorius commented on patch set 1 10/10/25, 16:38
Reply
Some tests also failed for empty height/width attributes, which occurred if an image cannot be processed. Before it was width="", with Fluid the attribute will be gone. Which is fine I think. There were also failed test cases where form elements had null as value, which is also omitted with Fluid 5. I think that‘s also fine and doesn‘t need special attention. WDYT? -
Simon Praetorius voted on patch set 1 CR +2 V +2 10/14/25, 16:48
-
Simon Praetorius merged patch set 2 10/14/25, 16:48
-
Simon Praetorius commented on patch set 2 10/14/25, 16:50
Reply Unresolved
Hope it's ok that I merged this now since the comment doesn't affect the fixes themselves. No matter what we do, this will come up once Fluid 5 gets integrated: Either the VHs need to be adjusted or the tests.