Review 12.4 Merged

91003[TASK] Update PHPStan to 2.1.31

Garvin Hicking CR +2 V +2 Normal +13 −175 updated 10/11/25, 06:04

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.31 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

PHPStan reports less errors on `@throws` annotations,
the baseline is adjusted.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Garvin Hicking commented on patch set 1 10/10/25, 16:22

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock
  2. Garvin Hicking uploaded patch set 2 10/10/25, 16:25

  3. Garvin Hicking uploaded patch set 3 10/10/25, 16:27

  4. core-ci voted on patch set 1 V -1 10/10/25, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86423

  5. core-ci voted on patch set 2 V -1 10/10/25, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86425

  6. core-ci voted on patch set 3 V +1 10/10/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86426

  7. Stefan Bürk marked it ready for review 10/11/25, 06:03

  8. Stefan Bürk voted on patch set 3 CR +2 V +2 10/11/25, 06:04

  9. Stefan Bürk merged patch set 4 10/11/25, 06:04