Review main Merged

91006[TASK] Remove readonly from PCPP arguments in `WidgetContext`

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 10/11/25, 06:08

Commit message

There is no need to declare properties readonly in case a
class is readonly, which makes all properties readonly by
default.

This change removes `readonly` from constructor properties
of `\TYPO3\CMS\Dashboard\Widgets\WidgetContext` because of
above mentioned reason.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Chris Müller +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 10/10/25, 20:47

  2. core-ci voted on patch set 1 V +1 10/10/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86438

  3. Georg Ringer commented on patch set 1 10/11/25, 04:04

    RemoveReadonlyPropertyVisibilityOnReadonlyClassRector::class rule of rector would help us avoid in future, wanna add it?
  4. Benjamin Franzke voted on patch set 1 CR +1 V +1 10/11/25, 05:09

  5. Chris Müller voted on patch set 1 CR +1 V +1 10/11/25, 05:23

  6. Benni Mack voted on patch set 1 CR +2 V +2 10/11/25, 06:08

  7. Benni Mack merged patch set 2 10/11/25, 06:08