91007[FEATURE] Improve Scheduler task group handling and display
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Lina Wolf +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/Sass/element/typo3-scheduler-editable-group-name.scssdeleted+0 −15
- Build/Sources/Sass/backend.scss+0 −1
- Build/Sources/TypeScript/scheduler/scheduler-add-group.ts+28 −0
- Build/Sources/TypeScript/scheduler/scheduler-editable-group-name.tsdeleted+0 −307
- typo3/sysext/backend/Resources/Public/Css/backend.css+0 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107668-ImproveSchedulerTaskGroupHandlingAndDisplay.rst2new+96 −0
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+40 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+7 −0
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php+2 −0
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task_group.php+23 −1
- typo3/sysext/scheduler/Resources/Private/Language/locallang_tca.xlf2+36 −0
- typo3/sysext/scheduler/Resources/Private/Partials/GroupUnusedList.html3+7 −8
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html5+8 −8
- typo3/sysext/scheduler/Resources/Private/Templates/ListTasks.html+0 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler-add-group.js+1 −1
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler-editable-group-name.jsdeleted+0 −13
Review log 2637
Show 912 earlier messages
-
Oli Bartsch uploaded patch set 1 10/10/25, 20:52
-
core-ci voted on patch set 1 V -1 10/10/25, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86439
-
Oli Bartsch uploaded patch set 2
V -110/11/25, 08:19 -
core-ci voted on patch set 2 V -1 10/11/25, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86457
-
Oli Bartsch uploaded patch set 3
V -110/11/25, 08:45 -
core-ci voted on patch set 3 V +1 10/11/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86460
-
Lina Wolf commented on patch set 3 10/12/25, 09:02
I wonder how this change is considered A11y wise. Meaning should not be transported by color (thinking of color blind etc) and how can we prevent color combinations without sufficient contrast? -
Garvin Hicking commented on patch set 3 10/12/25, 12:51
Reply
I would argue the color is purely cosmetical, as the meaning is transported via the group name already? -
Garvin Hicking commented on patch set 3 10/12/25, 12:53
Reply
functionality-wise, every task group is the same, so there's two options of distinction: color and text. We could argue whether an icon would make sense here? -
Lina Wolf commented on patch set 3 V +1 10/12/25, 13:52
Yeah, I had a look at it in rendered form and I think it should be fine a11y wise. The color does not transport meaning but is just another visual guide and also there is no danger of missing contrast destroying meaning -
Lina Wolf commented on patch set 3 CR +1 10/12/25, 13:54
Code also looks good -
Garvin Hicking commented on patch set 3 10/12/25, 16:48
Feature-107668-ImproveSchedulerTaskGroupHandlingAndDisplay.rst:52We should add a note here that TCA overrides are possible for custom color arrangements, and give a code examplelocallang_tca.xlf:77I think we should also have a grey / black color to indicate something like "not important groups"?GroupUnusedList.html:17I know we have several places in the core already that use inline styles which make restricting the CSP harder, so I wonder if we might have any way to prevent inline style? A webcomponent with dynamic colors? Emit+cache the existing colors and giving them names to refer to in CSS? Dynamically added CSS via the PageRenderer?TaskList.html:106(see other inline style note)TaskList.html:118We only have 5 places in the core that use `<i>` - I think we should try to avoid this in favor of `<em>` which is more common in the core?TaskGroupColorTest.php:32Hm these only really tests if database inserts work? I wonder if we should instead do a functional tests that checks that the scheduler group listing contains the color that has been assigned in the HTML output.
-
Garvin Hicking commented on patch set 3 10/12/25, 16:49
Should we align the border width to match the inline info boxes? See screenshot: https://www.dropbox.com/scl/fi/m9qebvlsttc2ibxvdv5x6/Screenshot-2025-10-12-at-18.48.38.png?rlkey=pwqvv0ldkbzf8saa7hvwes1wk&dl=0 it looks a bit "off" when I see these mismatching by a few pixels, so it feels a bit uneven? -
Garvin Hicking commented on patch set 3 10/12/25, 16:51
The button to create a new group only asks for a name. I think that modal should add some small text like "Tip: You can assign colors to groups if you edit the group". Assigning the colour within the modal popup would probably be a lot of work, and then we should also ask for the description. ... then again, maybe get rid of the modal alltogether and directly lead to the TCA "create new record" mask? -
Chris Müller commented on patch set 3 10/12/25, 17:08
TaskList.html:118ReplyI think, it depends: If the text has semantical meaning ("em" means emphasize), you are right. If this is just setting the text italic, because of ..., then "i" should be sufficient IMHO. -
Oli Bartsch uploaded patch set 4
CR +1V +110/13/25, 14:52 -
core-ci voted on patch set 4 V -1 10/13/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86554
-
Oli Bartsch commented on patch set 4 10/13/25, 15:02
Reply
No, I have used the 4px according to the labels in the page tree. I tried 8px but this looks odd in my eyes.Reply
I've added a small hint with a button to edit the whole record, which also forwards an already entered group name.Feature-107668-ImproveSchedulerTaskGroupHandlingAndDisplay.rst:52ReplyDonelocallang_tca.xlf:77ReplyI've added al colors from our Styleguide "Color Tokens", including gray.GroupUnusedList.html:17ReplyTHB the complete form engine is based on inline styles. Let's not misuse this patch for such reworks. This should be done in a whole in a separate patch.TaskList.html:106ReplySee other commentTaskList.html:118ReplyI think `<i>` is fine here as it is really only about the display without any meaning, similar to the pagination in the file list, which also uses `<i>`.TaskGroupColorTest.php:32ReplyYou are right, test makes no sense at all. Replaced this by proper acceptance tests. -
core-ci commented on patch set 4 10/13/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86554
-
core-ci commented on patch set 4 10/13/25, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86554
-
Oli Bartsch rebased onto patch set 5
V -110/13/25, 15:14 -
core-ci voted on patch set 5 V -1 10/13/25, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86558
-
Garvin Hicking commented on patch set 5 10/13/25, 15:36
GroupUnusedList.html:17ReplySure. But it's imo worth to discuss these shortcomings when they show up, just to maybe add an issue if someone agrees this could be worth addressing. -
Oli Bartsch uploaded patch set 6
V -110/13/25, 15:55 -
core-ci voted on patch set 6 V -1 10/13/25, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86567
-
Oli Bartsch uploaded patch set 7
V -110/13/25, 21:11 -
core-ci voted on patch set 7 V +1 10/13/25, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86581
-
Oli Bartsch uploaded patch set 8
V +110/13/25, 21:21 -
core-ci voted on patch set 8 V +1 10/13/25, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86582
-
Garvin Hicking voted on patch set 8 CR +1 V +1 10/13/25, 21:50
-
Oli Bartsch uploaded patch set 9
CR +1V +110/14/25, 07:54 -
core-ci voted on patch set 9 V +1 10/14/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86603
-
Garvin Hicking voted on patch set 9 CR +1 V +1 10/14/25, 08:10
-
Lina Wolf voted on patch set 9 CR +1 V +1 10/15/25, 07:39
-
Oli Bartsch voted on patch set 9 CR +2 V +2 10/15/25, 08:00
-
Oli Bartsch merged patch set 10 10/15/25, 08:01
-
Lina Wolf commented on patch set 10 10/17/25, 09:00
Unresolved
Please review related documentation: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91121