Review main Merged

91013[BUGFIX] Apply error class to Advanced Password fields

Josua Vogel CR +2 V +2 Easy +2 −4 updated 10/23/25, 09:11

Commit message

The error class is placed on the fields based on the validation results.
The validation error is attached to the parent property,
not to the individual fields "password" and "confirmation".

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Josua Vogel uploaded patch set 1 10/11/25, 15:36

  2. core-ci voted on patch set 1 V +1 10/11/25, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86468

  3. Sven Liebert voted on patch set 1 CR +1 V +1 10/13/25, 06:18

  4. Garvin Hicking commented on patch set 1 CR +2 V +2 10/23/25, 08:29

    This works well, thank you. I had to dig a bit to understand why it works for Password and not AdvancedPassword, so for anyone else reflecting on this: "Password" validates on the pure single input field itself. "AdvancedPassword" does validation in combination of multiple fields, so the result whether something failed or not is not "stored" inside the content of a single property, but in the "outer" validation result. This is now queried, and evaluated.
  5. Garvin Hicking merged patch set 2 10/23/25, 09:11