91014[TASK] Resolve some todos in SelectViewHelper
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Lina Wolf +1
- Josua Vogel +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Josua Vogel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1214
-
Torben Hansen uploaded patch set 1 10/11/25, 17:05
-
core-ci voted on patch set 1 V +1 10/11/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86473
-
Oliver Klee voted on patch set 1 CR +1 V +1 10/12/25, 08:57
-
Lina Wolf commented on patch set 1 10/12/25, 08:58
Can you give some hints how this can be tested? -
Oliver Klee commented on patch set 1 10/12/25, 08:58
Would a backport to 13.4 also make sense (so that both branches stay more in sync in order to make other backports less of a hassle)? -
Torben Hansen updated the commit message in patch set 2
CR +1V +110/12/25, 10:29 -
Torben Hansen commented on patch set 2 10/12/25, 10:31
Reply
We use the ViewHelper for example in ext:beuser. There, we have `Partials/BackendUser/Filter.html` and the field with the ID `tx_beuser_backendUserGroup`. Removing `optionValueField` allows you to test the patch (e.g. match in line 184)Reply
Thanks, I think this is ok. I updated the commit message. -
core-ci voted on patch set 2 V +1 10/12/25, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86489
-
Oliver Klee voted on patch set 2 CR +1 V +1 10/12/25, 10:59
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/12/25, 23:04
-
Josua Vogel voted on patch set 2 CR +1 V +1 10/31/25, 10:31
-
Lina Wolf voted on patch set 2 CR +1 10/31/25, 10:49
-
Christian Kuhn voted on patch set 2 CR +2 V +2 10/31/25, 11:37
-
Christian Kuhn merged patch set 3 10/31/25, 12:07