Review main Merged Breaking

91023[!!!][TASK] Drop `prepend` and `append` TCA modes from Value Picker

Benjamin Kott CR +2 V +2 Normal +171 −79 updated 10/14/25, 09:42

Commit message

We are removing the prepend and append modes from
the Value Picker used in FormEngina via TCA, as they
only cover a very niche use case and provide little
practical benefit.

There will be no direct replacement for these
options. If you still rely on them, we recommend
creating a custom input type that handles this
functionality and ensures proper accessibility
support.

Prepending or appending values to an existing
input is not an ideal pattern for input types,
as it often leads to unpredictable results and
inconsistent user experiences. It mixes
presentation and data logic, complicates input
validation, and can interfere with assistive
technologies. Instead, value selection should
focus on replacing or explicitly modifying the
input value in a controlled way.

In follow-up patches, we are reworking how
predefined values are selected by rebuilding the
Value Picker into new form and input types. The
existing replace mode will continue to be
supported, but the value picking mechanism will
evolve to provide a more consistent and accessible
experience.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1519

  1. Benjamin Kott uploaded patch set 1 10/13/25, 07:21

  2. core-ci voted on patch set 1 V +1 10/13/25, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86517

  3. Garvin Hicking commented on patch set 2 V +1 10/13/25, 07:37

    Published edit on patch set 1.
  4. Garvin Hicking voted on patch set 2 CR +1 V +1 10/13/25, 07:40

  5. core-ci voted on patch set 2 V +1 10/13/25, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86520

  6. Georg Ringer commented on patch set 2 10/13/25, 09:02

    can provide a tca mgiration at evening, but needs that!
  7. Oli Bartsch commented on patch set 2 10/13/25, 10:49

    custom FieldWizard
  8. Georg Ringer uploaded patch set 3 CR +1 V +1 10/13/25, 18:42

  9. core-ci voted on patch set 3 V +1 10/13/25, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86573

  10. Benjamin Franzke commented on patch set 3 10/14/25, 07:12

  11. Benjamin Franzke uploaded patch set 4 V +1 10/14/25, 07:21

  12. Benjamin Franzke commented on patch set 4 10/14/25, 07:22

    Reply

    Resolving, hope that's ok with you.
  13. core-ci voted on patch set 4 V +1 10/14/25, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86601

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 10/14/25, 07:54

  15. Benjamin Kott voted on patch set 4 CR +2 V +2 10/14/25, 07:54

  16. Benjamin Kott merged patch set 5 10/14/25, 07:54

  17. Oli Bartsch commented on patch set 5 10/14/25, 08:27

    Reply

    The need to add a complete new TCA type instead of just using existing type with all it's functionality and just extend for a FieldWizard would be the better migration. It's additionally quite hard especially for newcomers to really understand the type user.
  18. Benjamin Kott commented on patch set 5 10/14/25, 09:11

    Reply

    I do not think so, i was really referring to a new tca type "custom input type" that is specialized in rendering the use case, no field wizard can solve this.
  19. Oli Bartsch commented on patch set 5 10/14/25, 09:42

    Reply

    Done