Review main Merged

91024[TASK] Remove unused properties in PageRenderer

Benni Mack CR +2 V +2 Easy +18 −17 updated 10/13/25, 11:35

Commit message

PageRenderer properties jsFooterLibs, jsFooterInline and
jsFooterFiles are never evaluated but handed
in in some places.

They can be removed, as it makes further changes in this
class or the refactoring of the hooks easier.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 10/13/25, 09:40

  2. core-ci voted on patch set 1 V +1 10/13/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86523

  3. Benni Mack updated the commit message in patch set 2 V +1 10/13/25, 09:57

  4. core-ci voted on patch set 2 V +1 10/13/25, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86525

  5. Benni Mack uploaded patch set 3 V +1 10/13/25, 10:21

  6. Helmut Hummel commented on patch set 3 CR +1 V +1 10/13/25, 10:28

    Thanks!
  7. core-ci voted on patch set 3 V +1 10/13/25, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86531

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 10/13/25, 11:30

  9. Benni Mack voted on patch set 3 CR +2 V +2 10/13/25, 11:35

  10. Benni Mack merged patch set 4 10/13/25, 11:35