Review main Merged

91025[TASK] Move more LLL resolver logic into EXT:core

Benni Mack CR +2 V +2 Normal +60 −135 updated 12/10/25, 18:51

Commit message

This change reduces some additional runtime
cache logic for Extbase + EXT:form
and moves the code into a easier method (still internal)
called LanguageService->translate() which takes
the filename + key separately, and allows to return "null"
as well as argument mapping via vsprintf().

The runtime caches is superfluous as the loading of the
label files within LanguageService also has a runtime
cache.

The last call to the internal method includeLLFile()
is removed, as getLL() does not exist anymore.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1727

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 10/13/25, 09:41

  2. core-ci voted on patch set 1 V -1 10/13/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86524

  1. Benni Mack uploaded patch set 2 V -1 10/13/25, 12:42

  2. core-ci voted on patch set 2 V -1 10/13/25, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86540

  3. Benni Mack uploaded patch set 3 V -1 10/13/25, 13:22

  4. core-ci voted on patch set 3 V -1 10/13/25, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86544

  5. Benni Mack uploaded patch set 4 V -1 10/13/25, 14:34

  6. core-ci voted on patch set 4 V -1 10/13/25, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86549

  7. Benni Mack uploaded patch set 5 V -1 10/13/25, 14:46

  8. core-ci voted on patch set 5 V +1 10/13/25, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86552

  9. Benni Mack uploaded patch set 6 V +1 10/13/25, 15:41

  10. Benni Mack updated the commit message in patch set 7 10/13/25, 15:42

  11. Benni Mack rebased onto patch set 8 10/13/25, 15:54

  12. core-ci voted on patch set 6 V -1 10/13/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86562

  13. core-ci voted on patch set 7 V -1 10/13/25, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86563

  14. core-ci voted on patch set 8 V -1 10/13/25, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86565

  15. Benni Mack uploaded patch set 9 V -1 10/13/25, 16:10

  16. core-ci voted on patch set 9 V +1 10/13/25, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86569

  17. Oli Bartsch voted on patch set 9 CR +1 V +1 10/14/25, 07:57

  18. Benni Mack uploaded patch set 10 CR +1 V +1 10/14/25, 10:10

  19. core-ci voted on patch set 10 V +1 10/14/25, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86612

  20. Christian Kuhn voted on patch set 10 CR +1 V +1 10/14/25, 10:21

  21. Oli Bartsch voted on patch set 10 CR +1 V +1 10/14/25, 10:25

  22. Oliver Klee voted on patch set 10 V +1 10/14/25, 10:27

  23. Benni Mack voted on patch set 10 CR +2 V +2 10/14/25, 10:30

  24. Benni Mack merged patch set 11 10/14/25, 10:30

  25. Garvin Hicking commented on patch set 11 12/10/25, 18:51

    Unresolved