91031[BUGFIX] Allow alternative text for all file types
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Josef Glatz +1
- Garvin Hicking +1
- Josua Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Josef Glatz +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1315
-
Oli Bartsch uploaded patch set 1 10/13/25, 19:13
-
core-ci voted on patch set 1 V +1 10/13/25, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86574
-
Garvin Hicking commented on patch set 1 10/13/25, 19:41
sys_file_metadata.php:107I think this should allow also: application/postscript application/vnd.adobe.illustrator application/msword, application/vnd.openxmlformats-officedocument..... Thinking about this. Why not have alternative available always? Does it hurt? -
Oli Bartsch commented on patch set 1 10/13/25, 20:56
DisplayConditions.php:31ReplyNo, because this is internal.sys_file_metadata.php:107ReplyDoes ImageService really render a preview image for those types? -
Garvin Hicking commented on patch set 1 10/13/25, 21:22
sys_file_metadata.php:107ReplyI think this would technically be possible. but have not verified. I just think having alt everyhwere could be helpful and precents an IMO complicated displaycond. -
Josef Glatz commented on patch set 1 10/14/25, 05:34
Aside from the important RsT: I hope I'm in the right context, but having the alternative field for every file makes it possible to not only use an alt attribute on an IMG tag but also using that maintained field for other a11y attributes? e.g.: download button for word document where the alternative text is used for an aria-label attribute? -
Oli Bartsch uploaded patch set 2
V +110/14/25, 08:08 -
Oli Bartsch commented on patch set 2 10/14/25, 08:09
Reply
Good idea.sys_file_metadata.php:107ReplyAll right, I changed the patch to display the field for all types, see Josef's comment. -
core-ci voted on patch set 2 V +1 10/14/25, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86604
-
Garvin Hicking voted on patch set 2 CR +1 V +1 10/14/25, 08:51
-
Josef Glatz voted on patch set 2 CR +1 V +1 10/14/25, 14:00
-
Josef Glatz commented on patch set 2 10/15/25, 05:05
patch also successfully tested in v13 -
Josua Vogel voted on patch set 2 CR +1 10/15/25, 06:31
-
Oli Bartsch voted on patch set 2 CR +2 V +2 10/15/25, 07:37
-
Oli Bartsch merged patch set 3 10/15/25, 07:37
DisplayConditions.php:31