Review main Merged

91032[TASK] Improve rendering of record statistics

Georg Ringer CR +2 V +2 Easy +1 −0 updated 03/11/26, 09:53

Commit message

Order the data by the table name to group those
together which belong probably together.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2431

Show 56 earlier messages
  1. Georg Ringer uploaded patch set 1 10/13/25, 19:37

  2. Georg Ringer commented on patch set 1 10/13/25, 19:37

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/13/25, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86575

  4. Josef Glatz commented on patch set 1 CR +1 V +1 10/13/25, 19:47

    ✔ I really find the count much easier to read. 💯 Having a default sorting by raw table name is definitely a benefit for custom tables in real world projects!
  5. Oli Bartsch commented on patch set 1 10/13/25, 21:25

    I don't like that the title is "Records total / lost" but there might be just the totals number now in case non is lost. This seems wrong. What about making total bold and lost in (), so sth. like 10 (0). This looks more intuitiv I think.
  6. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 10/13/25, 21:45

  1. core-ci voted on patch set 2 V +1 10/13/25, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86583

  2. Josef Glatz commented on patch set 2 10/14/25, 05:25

    Reply

    For me it feels more intuitiv when I have to consume many lines (tested locally). However which solution will be introduced: what about adding another table column? Are we obliged not to use a separate table column for this? I've added some variants as screenshots to the issue! Take a look at https://forge.typo3.org/issues/107688#note-3 for some visual stuff
  3. Georg Ringer uploaded patch set 3 V +1 10/14/25, 12:12

  4. core-ci voted on patch set 3 V +1 10/14/25, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86624

  5. Josef Glatz voted on patch set 3 CR +1 V +1 10/15/25, 04:14

  6. Oli Bartsch commented on patch set 3 10/15/25, 11:46

    RecordStatistics.php:106

    What is the reason for this change? Or is this a leftover of another patchset?
  7. Georg Ringer commented on patch set 3 10/15/25, 11:54

    RecordStatistics.php:106 Reply

    left over but it is also more correct, it will be changed to a string later
  8. Oli Bartsch commented on patch set 3 10/15/25, 12:59

    RecordStatistics.php:106 Reply

    Where is this changed to a string? the only assignment is 108 and it’s a not cast.
  9. Georg Ringer commented on patch set 4 CR +1 V +1 01/21/26, 20:29

    Published edit on patch set 3.
  10. Georg Ringer rebased onto patch set 5 01/21/26, 20:31

    The following files contain Git conflicts: * typo3/sysext/reports/Classes/Report/RecordStatistics.php
  11. Georg Ringer commented on patch set 5 01/21/26, 20:31

    This change is ready for review.
  12. core-ci voted on patch set 4 V +1 01/21/26, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93972

  13. core-ci voted on patch set 5 V -1 01/21/26, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93973

  14. Georg Ringer uploaded patch set 6 V -1 01/21/26, 20:48

  15. core-ci voted on patch set 6 V +1 01/21/26, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93974

  16. Stefan Bürk commented on patch set 6 01/21/26, 23:09

    RecordStatistics.php:106 Reply

    ``` '/' . $lostRecordCount; ``` is a hidden (implicit) cast to concatenate the string. But only for the statement, the variable type is not changed. For example, a object ( \Stringable / having a __toString() method) would be casted to string using the method and what it returns even without a explicit cast.
  17. Georg Ringer rebased onto patch set 7 V +1 03/10/26, 03:53

  18. core-ci voted on patch set 7 V +1 03/10/26, 04:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97632

  19. Josef Glatz voted on patch set 7 CR +1 V +1 03/11/26, 04:51

  20. Oli Bartsch commented on patch set 7 03/11/26, 07:48

    RecordStatistics.php:106 Reply

    Acknowledged
  21. Josua Vogel voted on patch set 7 CR +1 V +1 03/11/26, 09:21

  22. Georg Ringer commented on patch set 7 03/11/26, 09:46

    Reply

    Done
  23. Benni Mack voted on patch set 7 CR +1 V +1 03/11/26, 09:48

  24. Georg Ringer voted on patch set 7 CR +2 V +2 03/11/26, 09:53

  25. Georg Ringer merged patch set 8 03/11/26, 09:53