Review main Abandoned

91033[BUGFIX] Add aria-label for language creation select

Georg Ringer CR 0 V -1 Easy +1 −1 updated 10/26/26, 20:35

Commit message

Add an aria-label attribute to the select in the page module
to create a new translation.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 2128

Show 23 earlier messages
  1. Georg Ringer uploaded patch set 1 10/13/25, 20:16

  2. Georg Ringer commented on patch set 1 10/13/25, 20:16

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/13/25, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86576

  1. Oli Bartsch voted on patch set 1 CR +1 V +1 10/13/25, 21:19

  2. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 10/13/25, 21:52

  3. core-ci voted on patch set 2 V +1 10/13/25, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86584

  4. Stefan Bürk commented on patch set 2 10/13/25, 22:18

    LanguageColumns.html:11

    I'm absolutly not into that accessibility topoc at all, but this would re-use the first select item label ... does this make really sense have it duplicated or would that be considered wrong also ? Just asking because I lack knowledge here.
  5. Georg Ringer commented on patch set 2 10/14/25, 05:45

    LanguageColumns.html:11 Reply

    @stefan@buerk.tech see the result, the 1st entry is kind of the label
  6. Josua Vogel voted on patch set 2 CR +1 V +1 10/15/25, 06:29

  7. Josef Glatz voted on patch set 2 V +1 10/15/25, 06:37

  8. Josef Glatz voted on patch set 2 CR +1 10/15/25, 09:30

  9. Sven Liebert commented on patch set 2 CR +1 V +1 10/22/25, 18:38

    LanguageColumns.html:11 Reply

    It's basically "Create a new translation of this page"
  10. Sven Liebert rebased onto patch set 3 CR +1 V +1 10/22/25, 19:33

  11. Sven Liebert commented on patch set 3 CR +1 V +1 10/22/25, 19:37

    Sorry some weired happend here when changing an other patch? I some kind of created a relation chain. That was not intended :O
  12. core-ci voted on patch set 3 V +1 10/22/25, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87292

  13. Sven Liebert uploaded patch set 4 10/22/25, 19:45

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  14. Sven Liebert uploaded patch set 5 10/22/25, 19:45

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  15. core-ci voted on patch set 4 V +1 10/22/25, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87298

  16. core-ci voted on patch set 5 V +1 10/22/25, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87299

  17. Stefan Bürk uploaded patch set 6 10/22/25, 20:01

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  18. Stefan Bürk commented on patch set 6 10/22/25, 20:08

    LanguageColumns.html:11 Reply

    * "Create a new translation of this page" * "Create a new translation of this page" * Lang 1 * Lang 2 As already mentioned - I'm not in the topic, but make that sense ... for example if that is read - is this not confusing for people not that "stupid" eye bound like me ? Just asking ...
  19. core-ci voted on patch set 6 V +1 10/22/25, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87302

  20. Josua Vogel commented on patch set 6 10/23/25, 05:57

    LanguageColumns.html:11 Reply

    I don't think that's ideal. It would be better if the label were something like “Translation,” “Language,” or “Page translation.”
  21. Mathias Brodala commented on patch set 6 10/23/25, 07:10

    LanguageColumns.html:11 Reply Unresolved

    Especially if the 1st item label is changed or even removed at some point. These must be separate, each with it's own purpose. In fact, the current 1st item is only labelled like this because the field itself lacks a label. So maybe consider fixing this instead, then you don't need an additional ARIA label because the plain field label does the job.
  22. Josua Vogel wrote 01/19/26, 16:57

    Removed reviewer Josua Vogel.
  23. Benni Mack updated the commit message in patch set 7 CR +1 V +1 04/22/26, 06:37

  24. core-ci voted on patch set 7 V -1 04/22/26, 07:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100742

  25. Garvin Hicking abandoned the change 10/26/26, 20:35

    see issue (reopnen if I'm wrongly assuming)