Review main Merged

91054[BUGFIX] Prevent unintended operations in FormEngine

Oli Bartsch CR +2 V +2 Normal +200 −13 updated 10/21/25, 20:17

Commit message

When FormEngine is loading or when it
gets reloaded, e.g. on changing the
record type, the doc header buttons
are now disabled to prevent unintended
operations, which previously could lead
to e.g. duplicated records.

Additionally, the `ShortcutButton` and
the `ButtonBarButton` do now also support
the disabled state functionality to
be in line with the other button types.

This is especially important since the
the shortcut button bar items were always
hidden behind the "ui-block" on form engine
initialization and therefore led to bad UX.

Now, buttons are properly disabled and visible,
providing better visual feedback to users during
the loading process.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/14/25, 07:53

  2. core-ci voted on patch set 1 V +1 10/14/25, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86602

  3. Oli Bartsch rebased onto patch set 2 V +1 10/15/25, 11:40

  4. core-ci voted on patch set 2 V +1 10/15/25, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86716

  5. Jochen Roth voted on patch set 2 CR +1 V +1 10/21/25, 08:10

  6. Benni Mack voted on patch set 2 CR +1 V +1 10/21/25, 15:46

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 10/21/25, 20:17

  8. Oli Bartsch merged patch set 3 10/21/25, 20:17