Review main Merged

91059[TASK] Clean up FileStorage\TreeController

Christian Kuhn CR +2 V +2 Normal +19 −121 updated 10/16/25, 10:26

Commit message

Reading #107683 its clear the controller could benefit from DI.
Going through the dependencies revealed FileStorageTreeProvider
could be made readonly as well: Open/closed file tree states
are stored in local browser storage since #103043, with server
side handling related property $expandedState being left unused.
Searching for 'stateHash' revealed an internal method in
BackendUtility is obsolete as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1012

  1. Christian Kuhn uploaded patch set 1 10/14/25, 10:55

  2. Christian Kuhn updated the commit message in patch set 2 10/14/25, 11:03

  3. core-ci voted on patch set 1 V +1 10/14/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86616

  4. core-ci voted on patch set 2 V +1 10/14/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86619

  5. Benni Mack voted on patch set 2 CR +1 V +1 10/14/25, 11:16

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 10/14/25, 11:22

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 10/14/25, 11:57

  8. Christian Kuhn merged patch set 3 10/14/25, 11:57

  9. Garvin Hicking commented on patch set 3 10/16/25, 06:57

    FYI, it seems this change introduces duplicate entries of all subfolders (see slack for screenshot). I can reproduce the error going away after reverting this patch. (If this is due to browser storage it might be a breaking change and we need a migration or Breaking rst to tell people how/if to reset their browser storage for this?)
  10. Oliver Hader commented on patch set 3 10/16/25, 07:29

    FileStorageTreeProvider.php:211

    This seems to be the problematic case. Previously the items were only provided in case the state was `expanded`. Now the item's are provided in any way. It seems the `loaded` and `expanded` stated need to be changed again - or the JavaScript side (`tree.ts`) to be aligned with these changes.
  11. Christian Kuhn commented on patch set 3 10/16/25, 09:01

    FileStorageTreeProvider.php:211 Reply

    thanks for pointer. i'll have a look.
  12. Christian Kuhn commented on patch set 3 10/16/25, 10:26

    FileStorageTreeProvider.php:211 Reply