91064[TASK] Remove TSFE->cObj and TSFE->newCObj()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 25
- typo3/sysext/extbase/Classes/Configuration/BackendConfigurationManager.php+1 −4
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+5 −1
- typo3/sysext/extbase/Classes/Utility/FrontendSimulatorUtility.phpdeleted+0 −59
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −28
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Link/ClickEnlargeViewHelper.php+15 −16
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+2 −2
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+4 −3
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+2 −2
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+1 −1
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManager.php+6 −2
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManagerInterface.php+3 −1
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+12 −13
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+5 −6
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php+5 −5
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+2 −2
- typo3/sysext/form/Tests/Functional/Mvc/Configuration/TypoScriptServiceTest.phpnew+51 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.php+14 −21
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/TypoScriptServiceTest.phpdeleted+0 −60
Show 5 more files
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php2+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −30
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+27 −20
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+25 −16
- typo3/sysext/redirects/Classes/Service/RedirectService.php+10 −8
Review log 1828
Show 3 earlier messages
-
core-ci voted on patch set 1 V +1 10/14/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86628
-
Christian Kuhn uploaded patch set 2
V +110/14/25, 13:25 -
core-ci voted on patch set 2 V +1 10/14/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86632
-
Christian Kuhn uploaded patch set 3
V +110/14/25, 14:27 -
Christian Kuhn uploaded patch set 4 10/14/25, 14:30
-
Christian Kuhn uploaded patch set 5 10/14/25, 14:35
-
core-ci voted on patch set 3 V +1 10/14/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86637
-
Christian Kuhn uploaded patch set 6 10/14/25, 14:38
-
core-ci voted on patch set 4 V +1 10/14/25, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86638
-
core-ci voted on patch set 5 V +1 10/14/25, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86639
-
core-ci voted on patch set 6 V +1 10/14/25, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86640
-
Christian Kuhn uploaded patch set 7
V +110/14/25, 14:52 -
core-ci voted on patch set 7 V +1 10/14/25, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86641
-
Christian Kuhn uploaded patch set 8
V +110/14/25, 15:11 -
Christian Kuhn updated the commit message in patch set 9 10/14/25, 15:24
-
core-ci voted on patch set 8 V -1 10/14/25, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86645
-
Christian Kuhn commented on patch set 9 CR -1 10/14/25, 15:27
missed some places that access the property using GLOBALS['TSFE']->cObj ... -
core-ci voted on patch set 9 V -1 10/14/25, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86647
-
Christian Kuhn uploaded patch set 10
CR -1V -110/14/25, 16:25 -
core-ci voted on patch set 10 V +1 10/14/25, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86653
-
Christian Kuhn commented on patch set 10 10/14/25, 17:52
Reply
Done -
Benni Mack voted on patch set 10 CR +1 V +1 10/14/25, 18:31
-
Stefan Bürk voted on patch set 10 CR +1 V +1 10/15/25, 05:58
-
Christian Kuhn voted on patch set 10 CR +2 V +2 10/15/25, 06:24
-
Christian Kuhn merged patch set 11 10/15/25, 06:24
AbstractContentObject.php:53