91070[FEATURE] Unified file creation via Element Browser
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 29
- Build/Sources/TypeScript/backend/drag-uploader.ts+28 −19
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+7 −11
- Build/Sources/TypeScript/filelist/resource-creation.tsrenamed+2 −2
- typo3/sysext/backend/Classes/View/FolderUtilityRenderer.phpdeleted+0 −227
- typo3/sysext/backend/Classes/View/ResourceUtilityRenderer.phpnew+362 −0
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+10 −10
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107697-UnifiedFileCreationInElementBrowser.rstnew+91 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+14 −6
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+10 −12
- typo3/sysext/filelist/Classes/Controller/File/CreateFileController.phpdeleted+0 −149
- typo3/sysext/filelist/Classes/Controller/File/EditFileController.php+3 −3
- typo3/sysext/filelist/Classes/Controller/File/FileUploadController.phpdeleted+0 −105
- typo3/sysext/filelist/Classes/Controller/FileListController.php+13 −43
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFileBrowser.phpnew+129 −0
- typo3/sysext/filelist/Classes/ElementBrowser/CreateFolderBrowser.php+5 −5
- typo3/sysext/filelist/Classes/ElementBrowser/FileBrowser.php+5 −4
- typo3/sysext/filelist/Classes/ElementBrowser/FolderBrowser.php+3 −3
- typo3/sysext/filelist/Classes/LinkHandler/FileLinkHandler.php+5 −4
- typo3/sysext/filelist/Classes/LinkHandler/FolderLinkHandler.php+3 −3
- typo3/sysext/filelist/Classes/FileList.php+1 −17
Show 9 more files
- typo3/sysext/filelist/Configuration/Backend/Routes.php+0 −12
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf+4 −4
- typo3/sysext/filelist/Resources/Private/Templates/ElementBrowser/ResourceCreation.htmlrenamed+7 −0
- typo3/sysext/filelist/Resources/Private/Templates/File/CreateFile.htmldeleted+0 −74
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+0 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/UploadFile.htmldeleted+0 −43
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/List.html+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/resource-creation.jsrenamed+1 −1
Review log 1621
-
Oli Bartsch uploaded patch set 1 10/15/25, 07:16
-
Oli Bartsch uploaded patch set 2 10/15/25, 07:17
-
core-ci voted on patch set 1 V +1 10/15/25, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86682
-
core-ci voted on patch set 2 V -1 10/15/25, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86683
-
Oli Bartsch rebased onto patch set 3
V -110/15/25, 07:29 -
core-ci voted on patch set 3 V +1 10/15/25, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86684
-
Oli Bartsch uploaded patch set 4
V +110/15/25, 08:32 -
core-ci voted on patch set 4 V +1 10/15/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86695
-
Oli Bartsch commented on patch set 4 10/15/25, 08:48
Because of new labels, review after executing `rm -rf typo3temp/var/cache/data`. -
Garvin Hicking updated the commit message in patch set 5
V +110/15/25, 09:35 -
Garvin Hicking commented on patch set 5 10/15/25, 09:43
It would be cool if the opened popup could highlight the selected directory that was previously selectedn the filelist? Then I would better see if I have switched subdirectories. (Other than that - seems to work well! Feels good!) -
core-ci voted on patch set 5 V +1 10/15/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86706
-
Oli Bartsch commented on patch set 5 10/15/25, 11:25
Reply
Thanks for testing. Selecting the folder is actually a general bug, which I've addressed here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91077. -
Benni Mack voted on patch set 5 CR +1 V +1 10/15/25, 15:32
-
Georg Ringer commented on patch set 5 V -1 10/15/25, 19:12
uploading a new file previously showed a notification "reload filelist, to enable the controls, the filelist has to be reloaded". this is not rendered anymore and the uploaded file can't be added. while in general it is *very* hard to find the just uploaded file again it should be still kind of the same as before -
Oli Bartsch commented on patch set 5 10/16/25, 08:23
Reply
The file list is reloaded automatically when closing the modal. There is no need for any notification. -
Georg Ringer voted on patch set 5 CR +1 V +1 10/16/25, 08:42
-
Oli Bartsch commented on patch set 5 10/16/25, 09:55
Reply
Done -
Oli Bartsch commented on patch set 5 10/17/25, 12:15
Reply
Done -
Oli Bartsch voted on patch set 5 CR +2 V +2 10/17/25, 12:15
-
Oli Bartsch merged patch set 6 10/17/25, 12:15