Review main Merged

91070[FEATURE] Unified file creation via Element Browser

Oli Bartsch CR +2 V +2 Expert +705 −762 updated 10/17/25, 12:15

Commit message

The file creation functionality has been migrated
from a separate page to the Element Browser modal
pattern, providing a unified and consistent interface
similar to the folder creation.

Key improvements:
- Single "New File" button opens modal with all file
  creation options
- Drag-and-drop upload with advanced duplication
  handling (replace, rename, skip, use existing) instead
  of the basic "override" checkbox
- Online media URL support (YouTube, Vimeo) integrated
  in same modal
- Text file creation for configured extensions
- File storage tree navigation remains visible
  and usable. No context loss.
- File extension filtering now automatically
  hides unusable forms now
- New files are directly visible in the file list,
  rendered below the creation options.

For unified naming, see e.g. the scheduler module,
the button labels are changed from "Create Folder/File"
to "New Folder/File".

The new `CreateFileBrowser` class is handling the
process and follows the `CreateFolderBrowser` pattern.

The `FolderUtilityRenderer` is renamed to
`ResourceUtilityRenderer` and now contains of
dedicated methods `createDragUpload()`, `addOnlineMedia()`,
`createRegularFile()` and `uploadForm()`, most with
optional `FileExtensionFilter` support. Now, any
combination of file creation possibilities can be displayed
in any component.

This change also allows to remove the standalone
upload functionality together with the corresponding
"Upload File" button.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 1621

  1. Oli Bartsch uploaded patch set 1 10/15/25, 07:16

  2. Oli Bartsch uploaded patch set 2 10/15/25, 07:17

  3. core-ci voted on patch set 1 V +1 10/15/25, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86682

  4. core-ci voted on patch set 2 V -1 10/15/25, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86683

  5. Oli Bartsch rebased onto patch set 3 V -1 10/15/25, 07:29

  6. core-ci voted on patch set 3 V +1 10/15/25, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86684

  7. Oli Bartsch uploaded patch set 4 V +1 10/15/25, 08:32

  8. core-ci voted on patch set 4 V +1 10/15/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86695

  9. Oli Bartsch commented on patch set 4 10/15/25, 08:48

    Because of new labels, review after executing `rm -rf typo3temp/var/cache/data`.
  10. Garvin Hicking updated the commit message in patch set 5 V +1 10/15/25, 09:35

  11. Garvin Hicking commented on patch set 5 10/15/25, 09:43

    It would be cool if the opened popup could highlight the selected directory that was previously selectedn the filelist? Then I would better see if I have switched subdirectories. (Other than that - seems to work well! Feels good!)
  12. core-ci voted on patch set 5 V +1 10/15/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86706

  13. Oli Bartsch commented on patch set 5 10/15/25, 11:25

    Reply

    Thanks for testing. Selecting the folder is actually a general bug, which I've addressed here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91077.
  14. Benni Mack voted on patch set 5 CR +1 V +1 10/15/25, 15:32

  15. Georg Ringer commented on patch set 5 V -1 10/15/25, 19:12

    uploading a new file previously showed a notification "reload filelist, to enable the controls, the filelist has to be reloaded". this is not rendered anymore and the uploaded file can't be added. while in general it is *very* hard to find the just uploaded file again it should be still kind of the same as before
  16. Oli Bartsch commented on patch set 5 10/16/25, 08:23

    Reply

    The file list is reloaded automatically when closing the modal. There is no need for any notification.
  17. Georg Ringer voted on patch set 5 CR +1 V +1 10/16/25, 08:42

  18. Oli Bartsch commented on patch set 5 10/16/25, 09:55

    Reply

    Done
  19. Oli Bartsch commented on patch set 5 10/17/25, 12:15

    Reply

    Done
  20. Oli Bartsch voted on patch set 5 CR +2 V +2 10/17/25, 12:15

  21. Oli Bartsch merged patch set 6 10/17/25, 12:15