Review main Merged

91072[TASK] Disable color scheme toggle if forced-colors mode is active

Elias Häußler CR +2 V +2 Easy +32 −11 updated 10/15/25, 21:24

Commit message

For accessibility reasons, users may enable a forced-colors mode in
their system or browser. In this case, applying a custom color scheme
(light mode or dark mode) does not have any effect. Hence, the color
scheme toggle is now disabled if the CSS media query
`(forced-colors: active)` matches and indicates the reduced
functionality.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Konstantin Hillmann +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Konstantin Hillmann +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1116

  1. Elias Häußler uploaded patch set 1 10/15/25, 07:50

  2. core-ci voted on patch set 1 V -1 10/15/25, 07:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86689

  3. Benjamin Franzke rebased onto patch set 2 V -1 10/15/25, 08:43

  4. Benjamin Franzke commented on patch set 2 10/15/25, 08:43

    color-scheme-switch.ts:78

    I'd actually be fine with hiding this element when forced colors is active. @michael.telgkamp@typo3.org what do you think?
  5. core-ci voted on patch set 2 V +1 10/15/25, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86700

  6. Garvin Hicking updated the commit message in patch set 3 V +1 10/15/25, 09:31

  7. Benjamin Franzke uploaded patch set 4 10/15/25, 09:33

  8. Benjamin Franzke commented on patch set 4 10/15/25, 09:33

    color-scheme-switch.ts:78 Reply

    Done
  9. Benjamin Franzke updated the commit message in patch set 5 CR +1 V +1 10/15/25, 09:34

  10. core-ci voted on patch set 3 V +1 10/15/25, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86703

  11. core-ci voted on patch set 4 V +1 10/15/25, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86704

  12. core-ci voted on patch set 5 V +1 10/15/25, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86705

  13. Konstantin Hillmann voted on patch set 5 CR +1 10/15/25, 12:41

  14. Konstantin Hillmann voted on patch set 5 V +1 10/15/25, 12:41

  15. Benjamin Franzke voted on patch set 5 CR +2 V +2 10/15/25, 18:06

  16. Benjamin Franzke merged patch set 6 10/15/25, 21:24