91079[TASK] Improve accessibility of live search button in backend toolbar
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Michael Telgkamp +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 2
Review log 910
-
Elias Häußler uploaded patch set 1 10/15/25, 12:47
-
Benjamin Franzke commented on patch set 1 10/15/25, 12:54
Requires the modal to be an actual dialog (`<dialog>` or `role="dialog"`), so we actually need this one first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91079 And I don't think we'll target 13.4 then. I'm marking as WIP for now. -
Benjamin Franzke marked it work in progress 10/15/25, 12:54
-
core-ci voted on patch set 1 V +1 10/15/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86724
-
Benjamin Franzke commented on patch set 1 10/15/25, 15:32
Reply
Sorry, I meant https://review.typo3.org/c/Packages/TYPO3.CMS/+/80871 -
Benjamin Franzke commented on patch set 1 CR +1 10/15/25, 20:48
This change is ready for review.Reply
Sorry, I missed that bootstrap already adds `role="dialog"` to our current modal implementation. This can be merged into main and 13.4. -
Benjamin Franzke voted on patch set 1 V +1 10/15/25, 21:33
-
Michael Telgkamp commented on patch set 1 CR +1 V +1 10/16/25, 06:39
Tested with Jaws (dialog announced), NVDA (dialog announced) and TalkBack (dialog not announced, as expected) -
Benjamin Franzke voted on patch set 1 CR +2 V +2 10/16/25, 06:44
-
Benjamin Franzke merged patch set 2 10/16/25, 06:55