91080[TASK] Be more precise on title for mobile-view search button in toolbar
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/80/91080/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/80/91080/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Markus Timtner +1
-
Verified V +1 Needs a vote
- Markus Timtner +1
- core-ci +1 CI
Merge conflicts 4
Issues 1
Files 3
Review log 1621
-
Elias Häußler uploaded patch set 1 10/15/25, 12:59
-
core-ci voted on patch set 1 V +1 10/15/25, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86726
-
Benni Mack commented on patch set 1 10/15/25, 14:29
In order to have updated translations for existing LTS versions, please create a new label, mark the old one as unused somehow with a x-typo3-deprecated=true attribute or something along the lines, and then create a new label. -
Elias Häußler commented on patch set 1 10/15/25, 15:03
Reply
I talked to Georg – the `typo3/sysext/backend/Resources/Private/Language/locallang_toolbar.xlf` file exists since https://review.typo3.org/c/Packages/TYPO3.CMS/+/84734 (13.2) and since we don't backport this patch to v12, the change should be fine as-is and we don't need to deprecate, rename or create new labels. -
Oliver Klee voted on patch set 1 CR +1 10/15/25, 15:07
-
Oli Bartsch commented on patch set 1 10/15/25, 15:21
We should also adjust the label used in typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/LiveSearchToolbarItem.html, which is the desktop variant. -
Elias Häußler commented on patch set 1 10/16/25, 11:02
Reply
I'm not sure if we should do this – the label is used on mobile as well (see https://forge.typo3.org/attachments/39927). -
Benjamin Franzke wrote 10/23/25, 02:48
Hashtag added: tas2025 -
Benni Mack wrote 04/21/26, 14:57
Removed cc Benni Mack. -
Benni Mack updated the commit message in patch set 2
CR +1V +104/22/26, 06:48 -
core-ci voted on patch set 2 V -1 04/22/26, 11:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100803
-
Riccardo De Contardi uploaded patch set 3
V -108/07/26, 10:01 -
core-ci voted on patch set 3 V -1 08/07/26, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106111
-
Riccardo De Contardi commented on patch set 4
V -108/07/26, 13:56Published edit on patch set 3. -
core-ci voted on patch set 4 V -1 08/07/26, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106120
-
Riccardo De Contardi uploaded patch set 5
V -108/07/26, 14:12 -
core-ci voted on patch set 5 V +1 08/07/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106121
-
Markus Timtner voted on patch set 5 CR +1 10/20/26, 17:44
-
Markus Timtner voted on patch set 5 V +1 10/20/26, 17:44
-
Benni Mack commented on patch set 5 11/14/26, 07:51
Reply
any plans on how to continue here @elias@haeussler.dev and @bo@cedev.de -
Elias Häußler commented on patch set 5 11/15/26, 10:26
Reply Unresolved
From my POV, this patch is ready. As already stated, I'd not change the label as suggested by @bo@cedev.de, because it would be imprecise for the mobile variant.