91081[BUGFIX] Add typecast to value checked in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1622
-
Georg Ringer uploaded patch set 1 10/15/25, 14:50
-
Georg Ringer commented on patch set 1 10/15/25, 14:51
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/15/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86735
-
Oliver Klee updated the commit message in patch set 2
V +110/15/25, 15:06 -
Oliver Klee updated the commit message in patch set 3 10/15/25, 15:06
-
Oli Bartsch commented on patch set 3 10/15/25, 15:10
DataHandler.php:2500I wonder why we do not apply the type cast on calling the method, so we can enforce a string in the parameter declaration. -
core-ci voted on patch set 2 V +1 10/15/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86739
-
core-ci voted on patch set 3 V +1 10/15/25, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86740
-
Stefan Bürk commented on patch set 3 10/15/25, 21:03
DataHandler.php:2500ReplyThought the same. Additionally, it does not make sense to check a empty string (or null) and do the whole processing or checks to do the further checks and working below and could be an early return ... or not ? -
Georg Ringer rebased onto patch set 4
V +112/29/25, 16:49 -
Georg Ringer uploaded patch set 5 12/29/25, 16:49
-
core-ci voted on patch set 4 V +1 12/29/25, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92777
-
core-ci voted on patch set 5 V +1 12/29/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92778
-
Benni Mack commented on patch set 5 01/23/26, 14:46
DataHandler.php:2500ReplyI personally would not add type cast to the methods, as it is a bugfix (to v13) ? -
Georg Ringer uploaded patch set 6
V +103/02/26, 19:33 -
core-ci voted on patch set 6 V +1 03/02/26, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97133
-
Lina Wolf commented on patch set 6 03/04/26, 06:00
DataHandler.php:2500ReplyThe typecast on the method call would work also in TYPO3 13. and it would stay in the current pattern as all other calls there are also cast to string. -
Lina Wolf commented on patch set 6 V +1 03/04/26, 06:01
This solves the issue for me. I am neutral on the code review, I would opt for calling the method with the declared type only, however this fix is fine to me as well -
Oliver Klee voted on patch set 6 CR +1 03/04/26, 08:09
-
Christian Kuhn commented on patch set 6 CR +1 V +1 03/04/26, 08:51
DataHandler.php:2500Replyi'd think the change is fine in set 6 variant with explicit cast when calling the method and not changing the method signature. this should be good as bugfix. -
Christian Kuhn voted on patch set 6 CR +2 V +2 03/04/26, 09:15
-
Christian Kuhn merged patch set 7 03/04/26, 09:15