Review main Merged

91084[FEATURE] Support for XLIFF 2.0 translation files

Benni Mack CR +2 V +2 Hard +400 −4 updated 10/17/25, 11:40

Commit message

TYPO3 now supports both XLIFF 1.2 and XLIFF 2+ translation
file formats. The loader automatically detects which version
is used by examining the namespace and version attribute,
making the transition seamless for integrators and extension
authors.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Chris Müller +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Chris Müller +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1317

  1. Benni Mack uploaded patch set 1 10/15/25, 15:17

  2. core-ci voted on patch set 1 V +1 10/15/25, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86742

  3. Benni Mack uploaded patch set 2 V +1 10/15/25, 16:07

  4. Chris Müller commented on patch set 2 10/15/25, 16:12

    XliffLoader.php:93

    If using an XLIFF file with version 2.1 or 2.2, it is considered as version 1.2. So, we should either support versions 2.1 and 2.2 or should add some exception/logging/etc. Otherwise it might be hard to spot the problem. AFAICS the difference between 2.0 and 2.1 (released Feb 2018)/2.2 (released March 2025) is nothing we should worry about for our purpose.
  5. core-ci voted on patch set 2 V +1 10/15/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86747

  6. Benni Mack uploaded patch set 3 V +1 10/15/25, 16:32

  7. Benni Mack commented on patch set 3 10/15/25, 16:32

    XliffLoader.php:93 Reply

    thx. fixed!
  8. core-ci voted on patch set 3 V +1 10/15/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86748

  9. Chris Müller commented on patch set 3 10/15/25, 16:44

    XliffLoader.php:93 Reply

    Thanks, should also the rst be adjusted?
  10. Chris Müller uploaded patch set 4 V +1 10/15/25, 17:07

  11. Chris Müller commented on patch set 4 10/15/25, 17:07

    XliffLoader.php:93 Reply

    Done
  12. core-ci voted on patch set 4 V +1 10/15/25, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86749

  13. Chris Müller voted on patch set 4 CR +1 V +1 10/15/25, 17:16

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 10/15/25, 17:23

  15. Georg Ringer voted on patch set 4 CR +2 V +2 10/15/25, 19:42

  16. Georg Ringer merged patch set 5 10/15/25, 19:42

  17. Lina Wolf commented on patch set 5 10/17/25, 11:40

    Unresolved

    Please review the documentation