Review main Merged

91086[TASK] Make Page object implement RecordInterface

Benni Mack CR +2 V +2 Normal +117 −2 updated 11/17/25, 11:06

Commit message

The Page object has been updated to implement the RecordInterface,
aligning it with the Record API introduced in TYPO3 v13.

This change adds:
- Implementation of RecordInterface with all required methods
- Internal use of RawRecord similar to the Record class
- ComputedProperties support for translation source and localized UIDs
- Backward compatibility with existing special properties and methods

The Page object now provides a consistent interface with other
record types while maintaining its page-specific functionality
like getLanguageId(), getPageId(), and getTranslationSource().

In the next patch of this series, we'll connect the Page object
to the RecordFactory, so it can handle subtypes as well.

Since Page is still internal, this shouldn't be a big problem.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2

Issues 1

Files 1

Review log 69

  1. Benni Mack uploaded patch set 1 10/15/25, 15:58

  2. core-ci voted on patch set 1 V +1 10/15/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86746

  3. Benni Mack updated the commit message in patch set 2 V +1 10/16/25, 19:35

  4. core-ci voted on patch set 2 V +1 10/16/25, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86839

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 10/16/25, 21:29

  6. Benni Mack rebased onto patch set 3 CR +1 V +1 11/17/25, 10:59

  7. Georg Ringer voted on patch set 3 CR +2 V +2 11/17/25, 10:59

  8. Georg Ringer merged patch set 4 11/17/25, 11:00

  9. core-ci voted on patch set 3 V +1 11/17/25, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89934