Review main Merged

91090[TASK] Migrate `dependsOnSubmodules` to appearance array

Oli Bartsch CR +2 V +2 Normal +28 −89 updated 10/20/25, 17:44

Commit message

The `dependsOnSubmodules` configuration option
has been moved from a top-level module configuration
option to the `appearance` array, aligning it with
similar options like `renderInModuleMenu`.

This change makes the module configuration API
more consistent and intuitive, as appearance-related
options are now grouped together.

The breaking rst is therefore no longer needed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 1825

  1. Oli Bartsch uploaded patch set 1 10/15/25, 18:09

  2. core-ci voted on patch set 1 V -1 10/15/25, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86757

  3. Oli Bartsch uploaded patch set 2 V -1 10/15/25, 18:35

  4. core-ci voted on patch set 2 V +1 10/15/25, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86759

  5. Garvin Hicking commented on patch set 2 10/15/25, 19:15

    isDependantOnSubmodules?
  6. Oli Bartsch commented on patch set 2 10/15/25, 19:41

    Reply

    what would be the benefit?
  7. Stefan Bürk commented on patch set 2 CR -1 10/15/25, 20:39

    `-1` based on not working state with this change

    Reply

    The benifit would be that it works. This change does not work, as the "protected" proeprty is not retrieved and the used ``` {subModule.doesDependOnSubmodules} ``` in the template always returns `NULL` instead of expected `FALSE` or `TRUE` (bool). See other comment within the fluid template.

    Modules.html:44

    To make this working `subModule` needs to ... * ... have a public property: `doesDependOnSubmodules` * ... requires either getter method `getDoesDependOnSubmodules()` or isser method `isDoesDependOnSubmodules()` Can be "checked" adding a fluid debug before this change and with this change: **before:** ``` <f:debug inline="true">{subModule.dependsOnSubmodules}</f:debug> ``` renders ``` Extbase Variable Dump FALSE ``` in the backend view for all cards of system extensions. **after:** ``` <f:debug inline="true">{subModule.doesDependOnSubmodules}</f:debug> ``` renders ``` Extbase Variable Dump NULL ``` Adding ``` public function getDoesDependOnSubmodules(): bool { return $this->doesDependOnSubmodules(); } ``` would render with the current fluid template the value correct again: ``` Extbase Variable Dump FALSE ``` Adding the option to the `web_info` main module renders ``` Extbase Variable Dump TRUE ``` but not with this change which would render wrong `NULL`.
  8. Stefan Bürk commented on patch set 2 10/15/25, 20:47

    > However, due to use in Fluid, we need to differintate the accessor form the property name. I do not get the reasoining here - why must it differ from the property name ? To keep it working in fluid with property like accees convention need to match, see other comments but `doesDependOnSubmodules()` is none of the supported possibilites by fluid (not listed all in the other comment).

    Modules.html:44 Reply

    ``` public function isDoesDependOnSubmodules(): bool { return $this->doesDependOnSubmodules(); } ``` also works .. (isser).
  9. Oli Bartsch uploaded patch set 3 CR -1 V +1 10/16/25, 07:37

  10. Oli Bartsch commented on patch set 3 10/16/25, 07:38

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Modules.html:44 Reply

    Done
  11. core-ci voted on patch set 3 V +1 10/16/25, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86788

  12. Garvin Hicking commented on patch set 3 10/16/25, 08:50

    doh I'm sorry, I always mix up "dependent" and "dependant". It needs to be "isDependent". I can try to fix tonight (no time now) if you want
  13. Oli Bartsch commented on patch set 3 V -1 10/16/25, 09:02

    Will solve this differently => this should go into the general `appearance` module config array instead as it only is a module menu thing.
  14. Oli Bartsch uploaded patch set 4 V +1 10/16/25, 09:53

  15. Oli Bartsch commented on patch set 4 10/16/25, 09:54

    Reply

    Done

    Reply

    Done
  16. core-ci voted on patch set 4 V +1 10/16/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86798

  17. Oli Bartsch uploaded patch set 5 V +1 10/17/25, 12:43

  18. core-ci voted on patch set 5 V -1 10/17/25, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86900

  19. Oli Bartsch uploaded patch set 6 V -1 10/17/25, 13:29

  20. core-ci voted on patch set 6 V +1 10/17/25, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86905

  21. Oli Bartsch rebased onto patch set 7 V +1 10/18/25, 09:57

  22. core-ci voted on patch set 7 V +1 10/18/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86971

  23. Benni Mack voted on patch set 7 CR +1 V +1 10/20/25, 10:20

  24. Georg Ringer voted on patch set 7 CR +2 V +2 10/20/25, 17:43

  25. Georg Ringer merged patch set 8 10/20/25, 17:44