91090[TASK] Migrate `dependsOnSubmodules` to appearance array
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/backend/Classes/Module/BaseModule.php+0 −10
- typo3/sysext/backend/Classes/Module/MenuModule.php+0 −5
- typo3/sysext/backend/Classes/Module/ModuleInterface.php+0 −6
- typo3/sysext/backend/Classes/Module/ModuleProvider.php+4 −2
- typo3/sysext/backend/Resources/Private/Partials/About/Modules.html3+1 −1
- typo3/sysext/backend/Tests/Functional/Module/ModuleProviderTest.php+15 −5
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107663-NewMethodInModuleInterface.rstdeleted+0 −56
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107663-DependsOnSubmodulesOptionForModules.rst+5 −3
- typo3/sysext/info/Configuration/Backend/Modules.php+3 −1
Review log 1825
-
Oli Bartsch uploaded patch set 1 10/15/25, 18:09
-
core-ci voted on patch set 1 V -1 10/15/25, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86757
-
Oli Bartsch uploaded patch set 2
V -110/15/25, 18:35 -
core-ci voted on patch set 2 V +1 10/15/25, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86759
-
Garvin Hicking commented on patch set 2 10/15/25, 19:15
isDependantOnSubmodules? -
Oli Bartsch commented on patch set 2 10/15/25, 19:41
Reply
what would be the benefit? -
Stefan Bürk commented on patch set 2 CR -1 10/15/25, 20:39
`-1` based on not working state with this changeReply
The benifit would be that it works. This change does not work, as the "protected" proeprty is not retrieved and the used ``` {subModule.doesDependOnSubmodules} ``` in the template always returns `NULL` instead of expected `FALSE` or `TRUE` (bool). See other comment within the fluid template.Modules.html:44To make this working `subModule` needs to ... * ... have a public property: `doesDependOnSubmodules` * ... requires either getter method `getDoesDependOnSubmodules()` or isser method `isDoesDependOnSubmodules()` Can be "checked" adding a fluid debug before this change and with this change: **before:** ``` <f:debug inline="true">{subModule.dependsOnSubmodules}</f:debug> ``` renders ``` Extbase Variable Dump FALSE ``` in the backend view for all cards of system extensions. **after:** ``` <f:debug inline="true">{subModule.doesDependOnSubmodules}</f:debug> ``` renders ``` Extbase Variable Dump NULL ``` Adding ``` public function getDoesDependOnSubmodules(): bool { return $this->doesDependOnSubmodules(); } ``` would render with the current fluid template the value correct again: ``` Extbase Variable Dump FALSE ``` Adding the option to the `web_info` main module renders ``` Extbase Variable Dump TRUE ``` but not with this change which would render wrong `NULL`. -
Stefan Bürk commented on patch set 2 10/15/25, 20:47
> However, due to use in Fluid, we need to differintate the accessor form the property name. I do not get the reasoining here - why must it differ from the property name ? To keep it working in fluid with property like accees convention need to match, see other comments but `doesDependOnSubmodules()` is none of the supported possibilites by fluid (not listed all in the other comment).Modules.html:44Reply``` public function isDoesDependOnSubmodules(): bool { return $this->doesDependOnSubmodules(); } ``` also works .. (isser). -
Oli Bartsch uploaded patch set 3
CR -1V +110/16/25, 07:37 -
Oli Bartsch commented on patch set 3 10/16/25, 07:38
Reply
DoneReply
DoneReply
DoneModules.html:44ReplyDone -
core-ci voted on patch set 3 V +1 10/16/25, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86788
-
Garvin Hicking commented on patch set 3 10/16/25, 08:50
doh I'm sorry, I always mix up "dependent" and "dependant". It needs to be "isDependent". I can try to fix tonight (no time now) if you want -
Oli Bartsch commented on patch set 3 V -1 10/16/25, 09:02
Will solve this differently => this should go into the general `appearance` module config array instead as it only is a module menu thing. -
Oli Bartsch uploaded patch set 4
V +110/16/25, 09:53 -
core-ci voted on patch set 4 V +1 10/16/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86798
-
Oli Bartsch uploaded patch set 5
V +110/17/25, 12:43 -
core-ci voted on patch set 5 V -1 10/17/25, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86900
-
Oli Bartsch uploaded patch set 6
V -110/17/25, 13:29 -
core-ci voted on patch set 6 V +1 10/17/25, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86905
-
Oli Bartsch rebased onto patch set 7
V +110/18/25, 09:57 -
core-ci voted on patch set 7 V +1 10/18/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86971
-
Benni Mack voted on patch set 7 CR +1 V +1 10/20/25, 10:20
-
Georg Ringer voted on patch set 7 CR +2 V +2 10/20/25, 17:43
-
Georg Ringer merged patch set 8 10/20/25, 17:44