91100[BUGFIX] Prevent language inheritance in form finishers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Sven Liebert +1
-
Verified V +2 Done
- Benni Mack +2
- Sven Liebert +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+2 −9
- typo3/sysext/form/Classes/Service/TranslationService.php9+32 −76
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+2 −1
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.html4+6 −2
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.txt+2 −2
Review log 3146
Show 1321 earlier messages
-
Josua Vogel uploaded patch set 1 10/16/25, 11:12
-
core-ci voted on patch set 1 V -1 10/16/25, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86806
-
Josua Vogel uploaded patch set 2
V -110/16/25, 22:25 -
core-ci voted on patch set 2 V -1 10/16/25, 22:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86851
-
Josua Vogel uploaded patch set 3
V -110/16/25, 22:41 -
core-ci voted on patch set 3 V +1 10/16/25, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86852
-
Josua Vogel updated the commit message in patch set 4
V +110/16/25, 22:51 -
core-ci voted on patch set 4 V +1 10/16/25, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86853
-
Josua Vogel updated the commit message in patch set 5
V +110/17/25, 14:56 -
core-ci voted on patch set 5 V +1 10/17/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86928
-
Josua Vogel uploaded patch set 6
V +111/25/25, 15:54 -
core-ci voted on patch set 6 V +1 11/25/25, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90965
-
Simon Schaufelberger commented on patch set 6 CR -1 01/15/26, 21:56
TranslationService.php:516use protected to be consistentDefault.fluid.html:1closing html tag missing -
Simon Schaufelberger commented on patch set 6 01/15/26, 23:21
TranslationService.php:511Replyscratch that. not important and matter of taste in this caseTranslationService.php:516Replyscratch that. not important and matter of taste in this case -
Christian Kuhn commented on patch set 6 01/15/26, 23:23
TranslationService.php:45looks as if the class could be declared readonly with the last property gone now? if so, please go ahead and do it in case you need to push again. -
Josua Vogel commented on patch set 7
CR -1V +101/16/26, 09:31Published edit on patch set 6. -
Josua Vogel commented on patch set 7 01/16/26, 09:31
TranslationService.php:45ReplyDoneDefault.fluid.html:1ReplyDone -
core-ci voted on patch set 7 V -1 01/16/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93571
-
Josua Vogel commented on patch set 8
V -101/16/26, 09:57Published edit on patch set 7. -
core-ci voted on patch set 8 V -1 01/16/26, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93574
-
Josua Vogel commented on patch set 9
V -101/16/26, 10:30Published edit on patch set 8.
-
Josua Vogel commented on patch set 9 01/16/26, 10:34
TranslationService.php:45Replyreadonly is not possible "on the fly" Error: Cannot generate lazy proxy with PHP < 8.3: class "TYPO3\CMS\Form\Service\Tr anslationService" is readonly. I wouldn´t change this for now -
core-ci voted on patch set 9 V +1 01/16/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93585
-
Simon Schaufelberger commented on patch set 9 01/21/26, 13:31
Default.fluid.html:2indentation too deep. should be 4 spaces -
Josua Vogel commented on patch set 10
V +101/21/26, 13:33Published edit on patch set 9. -
Josua Vogel commented on patch set 10 01/21/26, 13:37
Default.fluid.html:2ReplyDone -
core-ci voted on patch set 10 V -1 01/21/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93948
-
Josua Vogel commented on patch set 11
V -101/21/26, 13:54Published edit on patch set 10. -
core-ci voted on patch set 11 V +1 01/21/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93951
-
Simon Schaufelberger voted on patch set 11 CR +1 V +1 01/21/26, 14:05
-
Sven Liebert voted on patch set 11 CR +1 V +1 01/23/26, 10:39
-
Benni Mack commented on patch set 11 01/23/26, 15:34
TranslationService.php:99check out Locales->createLocaleFromRequest(), which you can then use to create the languageService -
Josua Vogel uploaded patch set 12
CR +1V +101/26/26, 07:52 -
Josua Vogel commented on patch set 12 01/26/26, 07:53
TranslationService.php:99ReplyDone -
core-ci voted on patch set 12 V -1 01/26/26, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94341
-
Josua Vogel uploaded patch set 13
V -101/26/26, 08:09 -
core-ci voted on patch set 13 V +1 01/26/26, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94343
-
Sven Liebert voted on patch set 13 CR +1 V +1 01/26/26, 08:30
-
Josua Vogel uploaded patch set 14
CR +1V +102/12/26, 19:14 -
core-ci voted on patch set 14 V +1 02/12/26, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95767
-
Sven Liebert voted on patch set 14 CR +1 V +1 02/13/26, 09:09
-
Josua Vogel updated the commit message in patch set 15
CR +1V +102/13/26, 09:34 -
Sven Liebert voted on patch set 15 CR +1 V +1 02/13/26, 09:47
-
core-ci voted on patch set 15 V +1 02/13/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95811
-
Benni Mack voted on patch set 15 CR +2 V +2 02/13/26, 11:21
-
Benni Mack merged patch set 16 02/13/26, 11:21
TranslationService.php:511