Review main Merged

91100[BUGFIX] Prevent language inheritance in form finishers

Josua Vogel CR +2 V +2 Normal +44 −90 updated 02/13/26, 11:21

Commit message

This fix removes the languageKey property from the TranslationService.
Since the service is a singleton, an overridden translation language
in one finisher was being inherited by subsequent finishers.

To retain the ability to translate emails consistently in a specific language using the existing option, the TranslateElementPropertyViewHelper has been extended with a new languageKey argument.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 3146

Show 1321 earlier messages
  1. Josua Vogel uploaded patch set 1 10/16/25, 11:12

  2. core-ci voted on patch set 1 V -1 10/16/25, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86806

  3. Josua Vogel uploaded patch set 2 V -1 10/16/25, 22:25

  4. core-ci voted on patch set 2 V -1 10/16/25, 22:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86851

  5. Josua Vogel uploaded patch set 3 V -1 10/16/25, 22:41

  6. core-ci voted on patch set 3 V +1 10/16/25, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86852

  7. Josua Vogel updated the commit message in patch set 4 V +1 10/16/25, 22:51

  8. core-ci voted on patch set 4 V +1 10/16/25, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86853

  9. Josua Vogel updated the commit message in patch set 5 V +1 10/17/25, 14:56

  10. core-ci voted on patch set 5 V +1 10/17/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86928

  11. Josua Vogel uploaded patch set 6 V +1 11/25/25, 15:54

  12. core-ci voted on patch set 6 V +1 11/25/25, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90965

  13. Simon Schaufelberger commented on patch set 6 CR -1 01/15/26, 21:56

    TranslationService.php:511

    use protected to be consistent

    TranslationService.php:516

    use protected to be consistent

    Default.fluid.html:1

    closing html tag missing
  14. Simon Schaufelberger commented on patch set 6 01/15/26, 23:21

    TranslationService.php:511 Reply

    scratch that. not important and matter of taste in this case

    TranslationService.php:516 Reply

    scratch that. not important and matter of taste in this case
  15. Christian Kuhn commented on patch set 6 01/15/26, 23:23

    TranslationService.php:45

    looks as if the class could be declared readonly with the last property gone now? if so, please go ahead and do it in case you need to push again.
  16. Josua Vogel commented on patch set 7 CR -1 V +1 01/16/26, 09:31

    Published edit on patch set 6.
  17. Josua Vogel commented on patch set 7 01/16/26, 09:31

    TranslationService.php:45 Reply

    Done

    Default.fluid.html:1 Reply

    Done
  18. core-ci voted on patch set 7 V -1 01/16/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93571

  19. Josua Vogel commented on patch set 8 V -1 01/16/26, 09:57

    Published edit on patch set 7.
  20. core-ci voted on patch set 8 V -1 01/16/26, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93574

  21. Josua Vogel commented on patch set 9 V -1 01/16/26, 10:30

    Published edit on patch set 8.
  1. Josua Vogel commented on patch set 9 01/16/26, 10:34

    TranslationService.php:45 Reply

    readonly is not possible "on the fly" Error: Cannot generate lazy proxy with PHP < 8.3: class "TYPO3\CMS\Form\Service\Tr anslationService" is readonly. I wouldn´t change this for now
  2. core-ci voted on patch set 9 V +1 01/16/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93585

  3. Simon Schaufelberger commented on patch set 9 01/21/26, 13:31

    Default.fluid.html:2

    indentation too deep. should be 4 spaces
  4. Josua Vogel commented on patch set 10 V +1 01/21/26, 13:33

    Published edit on patch set 9.
  5. Josua Vogel commented on patch set 10 01/21/26, 13:37

    Default.fluid.html:2 Reply

    Done
  6. core-ci voted on patch set 10 V -1 01/21/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93948

  7. Josua Vogel commented on patch set 11 V -1 01/21/26, 13:54

    Published edit on patch set 10.
  8. core-ci voted on patch set 11 V +1 01/21/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93951

  9. Simon Schaufelberger voted on patch set 11 CR +1 V +1 01/21/26, 14:05

  10. Sven Liebert voted on patch set 11 CR +1 V +1 01/23/26, 10:39

  11. Benni Mack commented on patch set 11 01/23/26, 15:34

    TranslationService.php:99

    check out Locales->createLocaleFromRequest(), which you can then use to create the languageService
  12. Josua Vogel uploaded patch set 12 CR +1 V +1 01/26/26, 07:52

  13. Josua Vogel commented on patch set 12 01/26/26, 07:53

    TranslationService.php:99 Reply

    Done
  14. core-ci voted on patch set 12 V -1 01/26/26, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94341

  15. Josua Vogel uploaded patch set 13 V -1 01/26/26, 08:09

  16. core-ci voted on patch set 13 V +1 01/26/26, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94343

  17. Sven Liebert voted on patch set 13 CR +1 V +1 01/26/26, 08:30

  18. Josua Vogel uploaded patch set 14 CR +1 V +1 02/12/26, 19:14

  19. core-ci voted on patch set 14 V +1 02/12/26, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95767

  20. Sven Liebert voted on patch set 14 CR +1 V +1 02/13/26, 09:09

  21. Josua Vogel updated the commit message in patch set 15 CR +1 V +1 02/13/26, 09:34

  22. Sven Liebert voted on patch set 15 CR +1 V +1 02/13/26, 09:47

  23. core-ci voted on patch set 15 V +1 02/13/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95811

  24. Benni Mack voted on patch set 15 CR +2 V +2 02/13/26, 11:21

  25. Benni Mack merged patch set 16 02/13/26, 11:21