Review main Abandoned

91108[WIP][TASK] Extract GraphicalFunctions configuration

Benni Mack CR 0 V 0 Hard +343 −222 updated 07/24/26, 20:19

Commit message

This change adds a new service class that only
resolves and holds configuration - ideally
used for IM/GM (GraphicalFunctions) and gdlib (GifBuilder)
so configuration can be decoupled from the
workers in the future.

The former install tool image test no longer
needs to specify imagefileExt formats on its own,
as the current configuration already matched the
needed formats (TODO: verify).

Tests are adapted and partially turned into
functional tests due to the usage of dependency
injection requirements.

TODO:
- testing
- do something about determineDefaultProcessingFileExtension
- more type safety / renaming?
- mark GraphicalSystemConfiguration @internal ?
- EnvironmentController->ImageInfo->GraphicalFunctions DI with
  lateboot

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 12

Review log 1017

  1. Benni Mack uploaded patch set 1 10/16/25, 19:16

  2. Benni Mack marked it work in progress 10/16/25, 19:31

  3. core-ci voted on patch set 1 V -1 10/16/25, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86836

  4. Garvin Hicking uploaded patch set 2 V -1 10/23/25, 16:01

  5. core-ci voted on patch set 2 V -1 10/23/25, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87435

  6. Garvin Hicking uploaded patch set 3 V -1 10/23/25, 16:25

  7. core-ci voted on patch set 3 V -1 10/23/25, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87436

  8. Garvin Hicking uploaded patch set 4 V -1 10/23/25, 21:15

  9. core-ci voted on patch set 4 V -1 10/23/25, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87448

  10. Garvin Hicking uploaded patch set 5 V -1 10/23/25, 21:39

  11. Garvin Hicking commented on patch set 5 10/23/25, 21:43

    Unresolved

    Tried to address a few test failures. EnvironmentController currently doesn't work to create an instance of GraphicalFunctions with the Service DI class. I guess due to the special DI failsafe container, even though I thought that was just recently removed to be required (https://review.typo3.org/c/Packages/TYPO3.CMS/+/90794).
  12. core-ci voted on patch set 5 V -1 10/23/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87449

  13. Garvin Hicking uploaded patch set 6 V -1 10/24/25, 12:08

  14. core-ci voted on patch set 6 V -1 10/24/25, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87491

  15. Garvin Hicking uploaded patch set 7 V -1 10/24/25, 14:35

    all your hacks are belong to me
  16. core-ci voted on patch set 7 V +1 10/24/25, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87513

  17. Benni Mack abandoned the change 07/24/26, 20:19