Review main Abandoned

91116[POC][WIP][TASK] Rework actions to use Buttons API

Garvin Hicking CR 0 V -1 Expert +1091 −536 updated 10/28/25, 14:23

Commit message

This is an alternativ approach trying to combine:

https://review.typo3.org/c/Packages/TYPO3.CMS/+/90383
https://review.typo3.org/c/Packages/TYPO3.CMS/+/89733

Idea:
* Use the VisualActionFactory API layer to
  ease Button creation with modern syntax
  (probably rename this to ButtonComponentFactory)
* Modernize Button API (use ENUMs, type declarations)

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 16

Review log 813

  1. Garvin Hicking uploaded patch set 1 10/17/25, 08:16

  2. Garvin Hicking wrote 10/17/25, 08:16

    Topic set to buttonbar
  3. Garvin Hicking uploaded patch set 2 10/17/25, 08:17

  4. core-ci voted on patch set 2 V +1 10/17/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86874

  5. core-ci voted on patch set 1 V -1 10/17/25, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86873

  6. Garvin Hicking uploaded patch set 3 V +1 10/17/25, 14:10

  7. core-ci voted on patch set 3 V +1 10/17/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86913

  8. Garvin Hicking commented on patch set 3 10/17/25, 14:48

    Unresolved

    Note to self: - Drop "Action" intermediate asap, use it only to figure out all the changes that are needed to the AbstractButton Interfaces - Keep the factory (naming?); replace current factory calls with fluent API calls to the instantiated "AbstractButton" object, sprinkle in new helpers (like IconIdentifier, IconSize) - Deprecate "makeXXXButton" pseudo factory calls, outline factory calls instead. Or keep it around if not hurting, to not make migrations hard for integrators where the actual output doesn't change much? Something like: ``` // Current Button generation $saveButton = '<a class="btn btn-default" href="' . htmlspecialchars($editLink) . '"' . ' title="' . htmlspecialchars($this->getLanguageService() ->sL('LLL:EXT:core/Resources/Private/Language/locallang_mod_web_list.xlf:edit')) . '">' . $this->iconFactory->getIcon($iconIdentifier, IconSize::SMALL)->render() . '</a>'; // How it would look like right now $saveButton = $buttonBar->makeInputButton() ->setName('save') ->setValue('1') ->setIcon($this->iconFactory->getIcon('actions-document-save', IconSize::SMALL)) ->setTitle('Save'); // How it could be $saveButton = $buttonfactory->create('input') ->setName('save') ->setValue('1') ->setIconIdentifier('actions-document-save') ->setIconSize(IconSize::SMALL) ->setTitle('Save'); ```
  9. Garvin Hicking uploaded patch set 4 V +1 10/23/25, 06:47

  10. core-ci voted on patch set 4 V +1 10/23/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87379

  11. Garvin Hicking uploaded patch set 5 V +1 10/24/25, 08:59

  12. core-ci voted on patch set 5 V -1 10/24/25, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87477

  13. Garvin Hicking abandoned the change 10/28/25, 14:23