91116[POC][WIP][TASK] Rework actions to use Buttons API
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Files 16
- typo3/sysext/backend/Classes/RecordList/Event/ModifyRecordListRecordActionsEvent.php+2 −1
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+259 −229
- typo3/sysext/backend/Classes/Template/Components/Buttons/AbstractButton.php+29 −65
- typo3/sysext/backend/Classes/Template/Components/Buttons/ButtonInterface.php+5 −9
- typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php+27 −68
- typo3/sysext/backend/Classes/View/Action/AbstractVisualAction.phpnew+31 −0
- typo3/sysext/backend/Classes/View/Action/ButtonAction.phpnew+53 −0
- typo3/sysext/backend/Classes/View/Action/CustomTagAction.phpnew+61 −0
- typo3/sysext/backend/Classes/View/Action/DividerAction.phpnew+44 −0
- typo3/sysext/backend/Classes/View/Action/DropdownContainerAction.phpnew+43 −0
- typo3/sysext/backend/Classes/View/Action/EmptyCellAction.phpnew+40 −0
- typo3/sysext/backend/Classes/View/Action/LinkAction.phpnew+58 −0
- typo3/sysext/backend/Classes/View/Action/VisualActionFactory.phpnew+68 −0
- typo3/sysext/backend/Classes/View/Action/VisualActionGroup.phpnew+47 −0
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/ButtonMarkupTest.phpnew+170 −0
- typo3/sysext/filelist/Classes/FileList.php+154 −164
Review log 813
-
Garvin Hicking uploaded patch set 1 10/17/25, 08:16
-
Garvin Hicking wrote 10/17/25, 08:16
Topic set to buttonbar -
Garvin Hicking uploaded patch set 2 10/17/25, 08:17
-
core-ci voted on patch set 2 V +1 10/17/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86874
-
core-ci voted on patch set 1 V -1 10/17/25, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86873
-
Garvin Hicking uploaded patch set 3
V +110/17/25, 14:10 -
core-ci voted on patch set 3 V +1 10/17/25, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86913
-
Garvin Hicking commented on patch set 3 10/17/25, 14:48
Unresolved
Note to self: - Drop "Action" intermediate asap, use it only to figure out all the changes that are needed to the AbstractButton Interfaces - Keep the factory (naming?); replace current factory calls with fluent API calls to the instantiated "AbstractButton" object, sprinkle in new helpers (like IconIdentifier, IconSize) - Deprecate "makeXXXButton" pseudo factory calls, outline factory calls instead. Or keep it around if not hurting, to not make migrations hard for integrators where the actual output doesn't change much? Something like: ``` // Current Button generation $saveButton = '<a class="btn btn-default" href="' . htmlspecialchars($editLink) . '"' . ' title="' . htmlspecialchars($this->getLanguageService() ->sL('LLL:EXT:core/Resources/Private/Language/locallang_mod_web_list.xlf:edit')) . '">' . $this->iconFactory->getIcon($iconIdentifier, IconSize::SMALL)->render() . '</a>'; // How it would look like right now $saveButton = $buttonBar->makeInputButton() ->setName('save') ->setValue('1') ->setIcon($this->iconFactory->getIcon('actions-document-save', IconSize::SMALL)) ->setTitle('Save'); // How it could be $saveButton = $buttonfactory->create('input') ->setName('save') ->setValue('1') ->setIconIdentifier('actions-document-save') ->setIconSize(IconSize::SMALL) ->setTitle('Save'); ``` -
Garvin Hicking uploaded patch set 4
V +110/23/25, 06:47 -
core-ci voted on patch set 4 V +1 10/23/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87379
-
Garvin Hicking uploaded patch set 5
V +110/24/25, 08:59 -
core-ci voted on patch set 5 V -1 10/24/25, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87477
-
Garvin Hicking abandoned the change 10/28/25, 14:23
abandoned for https://review.typo3.org/c/Packages/TYPO3.CMS/+/91288