Review 13.4 Merged

91122[BUGFIX] Fix access checks for nested modules

Oli Bartsch CR +2 V +2 Normal +203 −26 updated 10/17/25, 13:02

Commit message

Module access checks in ModuleProvider were
only performed up to 2 levels deep. While
direct access to this modules is prevented
by the middleware, this led to problems on
calculation of menus and also led to wrong
behaviour in combination with the new
`dependsOnSubmodules` functionality (#107663).

This patch introduces recursive access
filtering to properly check permissions
at all nesting levels.

Additionally, this is now verified by a
couple of new tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Oli Bartsch uploaded patch set 1 10/17/25, 10:13

  2. core-ci voted on patch set 1 V -1 10/17/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86889

  3. Oli Bartsch uploaded patch set 2 V -1 10/17/25, 12:39

  4. Oli Bartsch uploaded patch set 3 10/17/25, 12:40

  5. core-ci voted on patch set 2 V +1 10/17/25, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86898

  6. core-ci voted on patch set 3 V +1 10/17/25, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86899

  7. Oli Bartsch voted on patch set 3 CR +2 V +2 10/17/25, 13:02

  8. Oli Bartsch merged patch set 4 10/17/25, 13:02