91127[BUGFIX] Reset page renderer when performing subrequest
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageContentErrorHandler.php+6 −0
- typo3/sysext/core/Classes/Page/PageRenderer.php+3 −1
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/Fixtures/PageContentErrorHandlerUserFuncs.phpnew+40 −0
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/Fixtures/pages.csvnew+5 −0
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/Fixtures/PageWithPropagatedNotFoundResponse.typoscriptnew+18 −0
- typo3/sysext/core/Tests/Functional/Error/PageErrorHandler/PageContentErrorHandlerTest.phpnew+63 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+4 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+24 −17
Review log 3040
Show 1115 earlier messages
-
Torben Hansen uploaded patch set 1 10/17/25, 13:39
-
core-ci voted on patch set 1 V -1 10/17/25, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86907
-
Torben Hansen uploaded patch set 2
V -110/17/25, 13:51 -
core-ci voted on patch set 2 V +1 10/17/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86908
-
Oliver Klee voted on patch set 2 CR +1 12/08/25, 20:15
-
Torben Hansen updated the commit message in patch set 3
CR +1V +112/09/25, 06:38 -
core-ci voted on patch set 3 V +1 12/09/25, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91862
-
Torben Hansen updated the commit message in patch set 4
V +112/09/25, 07:59 -
core-ci voted on patch set 4 V +1 12/09/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91863
-
Oliver Klee voted on patch set 4 CR +1 12/09/25, 08:21
-
Oliver Klee commented on patch set 4 12/09/25, 08:59
Is there any way this can be covered with a functional test? -
Torben Hansen commented on patch set 4 12/09/25, 18:38
Reply
For functional test I would say no. Acceptance test would be an option, but requirements are pretty high (see issue description: page error handler, uncached extbase plugin which throws a `PropagateResponseException`, special request order in test execution, check for duplicate `body` tag). Adding this test scenario would however only make sense for me, if the patch is the right approach and a missing test is the only blocker for a merge. -
Oliver Klee commented on patch set 4 12/09/25, 18:45
Reply
Ack. -
Christian Weiske commented on patch set 4 CR +1 V +1 01/12/26, 09:44
I can confirm that this patch works on 12.4.40 as long as `bodyContent` is reset in `PageRenderer::reset()` as well. (This is missing in 12.4, and was added to v13 in "Harden array callbacks in EXT:core, part 3", commit 734a9a849411c34a714cd3445940d34e41d77974) -
Simon Schaufelberger voted on patch set 4 CR +1 V +1 01/26/26, 08:41
-
Georg Ringer voted on patch set 4 CR +1 03/04/26, 20:06
-
Jörg Bösche voted on patch set 4 CR +1 V +1 03/25/26, 16:04
-
Simon Schaufelberger uploaded patch set 5
CR +1V +103/30/26, 20:06 -
core-ci voted on patch set 5 V -1 03/30/26, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99115
-
Benni Mack updated the commit message in patch set 6
V -104/22/26, 06:44 -
core-ci voted on patch set 6 V -1 04/22/26, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100780
-
Oliver Klee commented on patch set 6 CR +1 05/03/26, 08:30
(Needs a rebase and conflict resolution, though.) -
Simon Schaufelberger uploaded patch set 7
CR +1V -105/09/26, 18:20 -
core-ci voted on patch set 7 V -1 05/09/26, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101758
-
Christian Kuhn wrote 06/18/26, 23:07
Removed reviewer Christian Kuhn. -
Simon Schaufelberger uploaded patch set 8
V -106/21/26, 11:45 -
core-ci voted on patch set 8 V +1 06/21/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103696
-
Simon Schaufelberger voted on patch set 8 CR +1 V +1 06/21/26, 11:53
-
Oliver Klee voted on patch set 8 CR +1 06/21/26, 19:38
-
Benjamin Kott uploaded patch set 9
CR +1V +108/24/26, 18:20 -
Benjamin Kott commented on patch set 9 08/24/26, 18:21
i´ve added the missing tests and also reenabled the site request tests -
Benjamin Kott voted on patch set 9 CR +1 V +1 08/24/26, 18:21
-
core-ci voted on patch set 9 V +1 08/24/26, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107046
-
Georg Ringer voted on patch set 9 CR +1 V +1 08/24/26, 18:55
-
Benjamin Franzke uploaded patch set 10
CR +1V +108/25/26, 07:13 -
Benjamin Kott voted on patch set 10 CR +1 V +1 08/25/26, 07:14
-
core-ci voted on patch set 10 V +1 08/25/26, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107072
-
Benjamin Franzke commented on patch set 10 08/25/26, 07:31
ack, voting this as a hack for the state we have 😊 -
Benjamin Kott voted on patch set 10 CR +2 V +2 08/25/26, 07:33
-
Benjamin Kott merged patch set 11 08/25/26, 08:31