91129[FEATURE] TranslateViewHelper supports new Translation Domain syntax
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107759-TranslateViewHelperSupportsTranslationDomainSyntax.rstnew+155 −0
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php5+24 −11
- typo3/sysext/extbase/Tests/Functional/Utility/LocalizationUtilityTest.php+8 −0
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php2+34 −11
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+20 −0
Review log 1620
-
Benni Mack uploaded patch set 1 10/17/25, 14:00
-
core-ci voted on patch set 1 V -1 10/17/25, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86911
-
Garvin Hicking commented on patch set 1 10/17/25, 14:38
-
Benni Mack commented on patch set 1 10/17/25, 14:51
LocalizationUtility.php:50Replythat's why I actually suggest to introduce the "domain" argument, so people start using it "properly". -
Benni Mack rebased onto patch set 2
V -110/17/25, 15:58 -
core-ci voted on patch set 2 V -1 10/17/25, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86937
-
Garvin Hicking commented on patch set 2 10/17/25, 19:15
LocalizationUtility.php:50ReplyMaybe then we should leave the "LLL" requirement stay UNLESS we have a "domain" argument? and then either rewire "key" to utilize shorthand notation, or use a "label" (or other) attrbute to reference the actual label? -
Lina Wolf commented on patch set 2 10/20/25, 10:41
LocalizationUtility.php:50ReplyI think it would be great if these 3 could work: ``` <f:translate key="LLL:core.common:delete" /> <f:translate key="core.common:delete" /> <f:translate key="delete" domain="core.common" /> ``` -
Benni Mack uploaded patch set 3
V -110/20/25, 14:08 -
core-ci voted on patch set 3 V -1 10/20/25, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87085
-
Benni Mack uploaded patch set 4
V -110/20/25, 15:01 -
core-ci voted on patch set 4 V +1 10/20/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87092
-
Benni Mack commented on patch set 4 10/20/25, 15:16
LocalizationUtility.php:50ReplyDone -
Georg Ringer voted on patch set 4 CR +1 V +1 10/20/25, 18:33
-
Stefan Bürk voted on patch set 4 CR +1 10/20/25, 18:59
-
Stefan Bürk voted on patch set 4 V +1 10/20/25, 19:06
-
Benni Mack voted on patch set 4 CR +2 V +2 10/20/25, 21:44
-
Benni Mack merged patch set 5 10/20/25, 21:44
-
Lina Wolf commented on patch set 5 10/26/25, 10:50
TranslateViewHelper.php:103From reading the code I believe this means that when the ViewHelper has a default value set AND uses the domain translation syntax without LLL: prefix then the default value will be returned and not the value of the translation file. is this behavioiur intended? -
Lina Wolf commented on patch set 5 10/26/25, 11:00
TranslateViewHelper.php:103ReplyWrote a test to verify this, it seems like it is indeed a bug, opened an issue: https://forge.typo3.org/issues/107841
LocalizationUtility.php:50