91130[DOCS] Use correct method in file upload configuration code example
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
-
Verified V +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 1
Review log 711
-
TYPO3com uploaded patch set 1 10/17/25, 14:12
-
Chris Müller updated the commit message in patch set 2 10/17/25, 14:22
-
core-ci voted on patch set 1 V +1 10/17/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86914
-
core-ci voted on patch set 2 V +1 10/17/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86918
-
Sven Liebert voted on patch set 2 CR +1 V +1 10/17/25, 15:06
-
Stefan Bürk commented on patch set 2 10/17/25, 17:44
The commit message title does not make sense, it should not "say" what was wrong and instead mention what is done/archieved. Currently, the title would emphasize that the change intentionally points to a non-existing method. Beside that, as this is related to a documentation/changelog entry, we could use the `[DOCS]` prefix instead. I would suggest something like: ``` [DOCS] Use correct method for file upload configuration code example ``` -
Stefan Bürk updated the commit message in patch set 3
CR +1V +110/17/25, 17:45 -
Stefan Bürk commented on patch set 3 CR +1 V +1 10/17/25, 17:45
Reply
Done -
core-ci voted on patch set 3 V +1 10/17/25, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86944
-
Garvin Hicking voted on patch set 3 CR +2 V +2 10/17/25, 17:55
-
Garvin Hicking merged patch set 4 10/17/25, 18:11