Review main Merged

91130[DOCS] Use correct method in file upload configuration code example

TYPO3com CR +2 V +2 Easy +1 −1 updated 10/17/25, 18:11

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 711

  1. TYPO3com uploaded patch set 1 10/17/25, 14:12

  2. Chris Müller updated the commit message in patch set 2 10/17/25, 14:22

  3. core-ci voted on patch set 1 V +1 10/17/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86914

  4. core-ci voted on patch set 2 V +1 10/17/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86918

  5. Sven Liebert voted on patch set 2 CR +1 V +1 10/17/25, 15:06

  6. Stefan Bürk commented on patch set 2 10/17/25, 17:44

    The commit message title does not make sense, it should not "say" what was wrong and instead mention what is done/archieved. Currently, the title would emphasize that the change intentionally points to a non-existing method. Beside that, as this is related to a documentation/changelog entry, we could use the `[DOCS]` prefix instead. I would suggest something like: ``` [DOCS] Use correct method for file upload configuration code example ```
  7. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 10/17/25, 17:45

  8. Stefan Bürk commented on patch set 3 CR +1 V +1 10/17/25, 17:45

    Reply

    Done
  9. core-ci voted on patch set 3 V +1 10/17/25, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86944

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 10/17/25, 17:55

  11. Garvin Hicking merged patch set 4 10/17/25, 18:11