Review main Merged

91133[DOCS] Add propertiesExcludedFromTranslation finisher option

Josua Vogel CR +2 V +2 Hard +314 −0 updated 10/23/25, 09:10

Commit message

This fix adds the propertiesExcludedFromTranslation feature to the
form documentation.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 2127

Show 2 earlier messages
  1. Josua Vogel uploaded patch set 1 10/17/25, 14:28

  2. Josua Vogel uploaded patch set 2 10/17/25, 14:29

  1. core-ci voted on patch set 1 V -1 10/17/25, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86919

  2. core-ci voted on patch set 2 V -1 10/17/25, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86922

  3. Josua Vogel uploaded patch set 3 V -1 10/17/25, 14:54

  4. core-ci voted on patch set 3 V +1 10/17/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86927

  5. Sven Liebert voted on patch set 3 CR +1 V +1 10/21/25, 15:38

  6. Oli Bartsch commented on patch set 3 CR -1 10/22/25, 10:25

    Index.rst:42

    the confval is just `translation.propertiesExcludedFromTranslation` and it should go the "Additional options section" since this can not be set in form editor. See EmailFinsiher which declares this section

    Index.rst:78

    Let's add a _codesnippets for the `propertiesExcludedFromTranslation` option.

    Index.rst:183

    Let's just use the actually confval, see other options below and lets add the option to the codesnippet "_example_email.yaml"

    Index.rst:77

    Let's just use the actually confval, see other options.

    Index.rst:61

    the confval is just translation.propertiesExcludedFromTranslation and it should go the "Additional options section" since this can not be set in form editor.

    Index.rst:172

    the confval is just translation.propertiesExcludedFromTranslation
  7. Lina Wolf commented on patch set 3 CR -1 10/22/25, 10:28

    On it...
  8. Lina Wolf commented on patch set 3 10/22/25, 11:57

    Index.rst:189

    I think there is a mix up here, translation.propertiesExcludedFromTranslation is not about enforcing languages but about excluding labels from translation...
  9. Lina Wolf uploaded patch set 4 CR +1 V +1 10/22/25, 12:09

  10. Lina Wolf commented on patch set 4 10/22/25, 12:12

    I uploaded a patch applying the changes. For some reason the description of the property was not what is mentioned in the according changelog entry [Feature: #90919 - Skip translation of overridden form finisher options ](https://docs.typo3.org/permalink/changelog:feature-90919) So I adjusted the description, however I have never used the option myself.

    Index.rst:42 Reply

    Done

    Index.rst:183 Reply

    Done

    Index.rst:189 Reply

    Done

    Index.rst:77 Reply

    Done

    Index.rst:61 Reply

    Done

    Index.rst:172 Reply

    Done
  11. Lina Wolf commented on patch set 4 10/22/25, 12:12

    Index.rst:78 Reply

    Done
  12. Lina Wolf commented on patch set 4 CR +1 V +1 10/22/25, 12:13

    I tried out the rendering, works fine and adjusted the texts to fit the changelog entry
  13. core-ci voted on patch set 4 V -1 10/22/25, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87250

  14. Lina Wolf uploaded patch set 5 CR +1 V +1 10/22/25, 13:22

  15. Lina Wolf voted on patch set 5 CR +1 V +1 10/22/25, 13:23

  16. core-ci voted on patch set 5 V +1 10/22/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87266

  17. Sven Liebert voted on patch set 5 CR +1 V +1 10/22/25, 18:26

  18. Garvin Hicking voted on patch set 5 CR +2 V +2 10/23/25, 08:42

  19. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 10/23/25, 08:49

  20. Garvin Hicking commented on patch set 6 CR +1 V +1 10/23/25, 08:51

    Removed 12.4 target from the commit because due to structural changes this would be way too much effort to backport this to the "old" structure.
  21. Lina Wolf voted on patch set 6 CR +1 V +1 10/23/25, 08:53

  22. Sven Liebert voted on patch set 6 CR +1 V +1 10/23/25, 08:54

  23. core-ci voted on patch set 6 V +1 10/23/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87390

  24. Garvin Hicking voted on patch set 6 CR +2 V +2 10/23/25, 09:10

  25. Garvin Hicking merged patch set 7 10/23/25, 09:10