91133[DOCS] Add propertiesExcludedFromTranslation finisher option
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Lina Wolf +1
- Sven Liebert +1
-
Verified V +2 Done
- Garvin Hicking +2
- Lina Wolf +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/_codesnippets/_form_with_propertiesExcludedFromTranslation.yamlnew+17 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/Index.rst4+41 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/Index.rst4+12 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/Index.rst2+20 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/RedirectFinisher/Index.rst2+20 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/Index.rst2+20 −0
- typo3/sysext/form/Documentation/I/Concepts/FrontendRendering/Index.rst+10 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/Confirmation.rst+29 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/EmailToReceiver.rst+29 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/EmailToSender.rst+29 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/FlashMessage.rst+29 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/Redirect.rst+29 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/SaveToDatabase.rst+29 −0
Review log 2127
Show 2 earlier messages
-
core-ci voted on patch set 1 V -1 10/17/25, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86919
-
core-ci voted on patch set 2 V -1 10/17/25, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86922
-
Josua Vogel uploaded patch set 3
V -110/17/25, 14:54 -
core-ci voted on patch set 3 V +1 10/17/25, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86927
-
Sven Liebert voted on patch set 3 CR +1 V +1 10/21/25, 15:38
-
Oli Bartsch commented on patch set 3 CR -1 10/22/25, 10:25
Index.rst:78Let's add a _codesnippets for the `propertiesExcludedFromTranslation` option.Index.rst:183Let's just use the actually confval, see other options below and lets add the option to the codesnippet "_example_email.yaml"Index.rst:77Let's just use the actually confval, see other options.Index.rst:61the confval is just translation.propertiesExcludedFromTranslation and it should go the "Additional options section" since this can not be set in form editor.Index.rst:172the confval is just translation.propertiesExcludedFromTranslation -
Lina Wolf commented on patch set 3 CR -1 10/22/25, 10:28
On it... -
Lina Wolf commented on patch set 3 10/22/25, 11:57
Index.rst:189I think there is a mix up here, translation.propertiesExcludedFromTranslation is not about enforcing languages but about excluding labels from translation... -
Lina Wolf uploaded patch set 4
CR +1V +110/22/25, 12:09 -
Lina Wolf commented on patch set 4 10/22/25, 12:12
I uploaded a patch applying the changes. For some reason the description of the property was not what is mentioned in the according changelog entry [Feature: #90919 - Skip translation of overridden form finisher options ](https://docs.typo3.org/permalink/changelog:feature-90919) So I adjusted the description, however I have never used the option myself.Index.rst:42ReplyDoneIndex.rst:183ReplyDoneIndex.rst:189ReplyDoneIndex.rst:77ReplyDoneIndex.rst:61ReplyDoneIndex.rst:172ReplyDone -
Lina Wolf commented on patch set 4 10/22/25, 12:12
Index.rst:78ReplyDone -
Lina Wolf commented on patch set 4 CR +1 V +1 10/22/25, 12:13
I tried out the rendering, works fine and adjusted the texts to fit the changelog entry -
core-ci voted on patch set 4 V -1 10/22/25, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87250
-
Lina Wolf uploaded patch set 5
CR +1V +110/22/25, 13:22 -
Lina Wolf voted on patch set 5 CR +1 V +1 10/22/25, 13:23
-
core-ci voted on patch set 5 V +1 10/22/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87266
-
Sven Liebert voted on patch set 5 CR +1 V +1 10/22/25, 18:26
-
Garvin Hicking voted on patch set 5 CR +2 V +2 10/23/25, 08:42
-
Garvin Hicking updated the commit message in patch set 6
CR +1V +110/23/25, 08:49 -
Garvin Hicking commented on patch set 6 CR +1 V +1 10/23/25, 08:51
Removed 12.4 target from the commit because due to structural changes this would be way too much effort to backport this to the "old" structure. -
Lina Wolf voted on patch set 6 CR +1 V +1 10/23/25, 08:53
-
Sven Liebert voted on patch set 6 CR +1 V +1 10/23/25, 08:54
-
core-ci voted on patch set 6 V +1 10/23/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87390
-
Garvin Hicking voted on patch set 6 CR +2 V +2 10/23/25, 09:10
-
Garvin Hicking merged patch set 7 10/23/25, 09:10
Index.rst:42